libbpfgo icon indicating copy to clipboard operation
libbpfgo copied to clipboard

Published 20 hours ago • verified publisher icon aquasecurity

Add selftest for cgroup attach

Open mozillazg opened this issue 1 year ago • 1 comments

https://github.com/aquasecurity/libbpfgo/pull/196

mozillazg avatar Aug 09 '22 13:08 mozillazg

selftest:

image

mozillazg avatar Aug 09 '22 13:08 mozillazg

I have no idea how this happened : https://github.com/aquasecurity/libbpfgo/runs/7815708108?check_suite_focus=true image

Maybe we should use make instead of make -j8 in Makefile?: https://github.com/aquasecurity/libbpfgo/blob/0850b8cf46a9610acbe6b2c8503fb69a88af4243/Makefile#L129-L138

mozillazg avatar Aug 13 '22 01:08 mozillazg

I have no idea how this happened : https://github.com/aquasecurity/libbpfgo/runs/7815708108?check_suite_focus=true

The difference is that the prior error was in Unit Tests, the one that you triggered is in Selftests.

It seems related to https://github.com/aquasecurity/libbpfgo/pull/209#issuecomment-1212114414. I'm doing some tests right now with https://github.com/aquasecurity/libbpfgo/pull/212.

geyslan avatar Aug 13 '22 01:08 geyslan

Maybe we should use make instead of make -j8 in Makefile?:

https://github.com/aquasecurity/libbpfgo/blob/0850b8cf46a9610acbe6b2c8503fb69a88af4243/Makefile#L129-L138

Hey @mozillazg, the "-j8" was a way to "accelerate" the libbpf builds by default in most of the envs (even when no number of jobs was informed). If it is causing issue we can remove it for sure (and rely in -j argument).

rafaeldtinoco avatar Aug 15 '22 11:08 rafaeldtinoco