kube-hunter icon indicating copy to clipboard operation
kube-hunter copied to clipboard

Published 20 hours ago • verified publisher icon aquasecurity

Add content search for the KB

Open itaysk opened this issue 5 years ago • 7 comments

Currently the search is more like a lookup, where you can lookup an article by it's ID. We need a full text search to allow people to search for content freely.

itaysk avatar Oct 23 '19 06:10 itaysk

Can we run some backend logic on GitHub pages to do that? What is the common way to do this on that platform?

iyehuda avatar Oct 23 '19 16:10 iyehuda

No. We can do client side, or server side hosted as a service. There are several of those that work with Jekyll like algolia/lunr just to give an example

itaysk avatar Oct 23 '19 16:10 itaysk

how about something like this Screenshot-20191024102538-962x673

RobbiNespu avatar Oct 24 '19 02:10 RobbiNespu

see my comments on the PR

itaysk avatar Oct 24 '19 06:10 itaysk

I think it would be best to use some external search indexing service. One option is Google custom search. It's free but ad supported. Another is Algolia which is free for not-commercial project which I guess we qualify.

itaysk avatar Oct 24 '19 11:10 itaysk

That sounds overkill, this seems a more appropriate solution if possible: http://elasticlunr.com/

RaitoBezarius avatar Oct 31 '19 21:10 RaitoBezarius

@RaitoBezarius if that can support full text indexing (of the content) that's an option too

itaysk avatar Nov 01 '19 06:11 itaysk