kube-bench icon indicating copy to clipboard operation
kube-bench copied to clipboard

Introduce new statuses: SKIP, MANU, ERRO

Open hypnoglow opened this issue 2 years ago • 5 comments

This changeset introduces new statuses as proposed in #916

Probably I missed something, so I would be grateful any feedback and help 🙏

hypnoglow avatar Oct 31 '21 16:10 hypnoglow

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 31 '21 16:10 CLAassistant

Codecov Report

Merging #1035 (85e4b94) into main (cc619e5) will decrease coverage by 0.22%. The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   63.56%   63.34%   -0.23%     
==========================================
  Files          14       14              
  Lines        1905     1934      +29     
==========================================
+ Hits         1211     1225      +14     
- Misses        633      647      +14     
- Partials       61       62       +1     
Impacted Files Coverage Δ
cmd/util.go 67.23% <ø> (ø)
cmd/common.go 54.54% <57.14%> (+0.20%) :arrow_up:
check/controls.go 75.68% <70.37%> (-3.92%) :arrow_down:
check/check.go 83.54% <80.00%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc619e5...85e4b94. Read the comment docs.

codecov[bot] avatar Nov 01 '21 12:11 codecov[bot]

@yoavrotems I've made a few changes based on your comments, PTAL. Although I'm not sure I got everything correct 🙄

hypnoglow avatar Nov 05 '21 16:11 hypnoglow

Before I'm reviewing those new changes, we talked about it with some kube-bench users, and those changes are breaking the output for automation and other projects using kube-bench so lets do it for now as a flag, for example --enhancedoutput, and then it will be default to true, and if someone needs backward compatibility they could run it as ./kube-bench --enhancedoutput=false . It's important to say that this output with more status will be the default, and returning to the old status will have to be specifically chosen.
It will be part of 0.7.0 and in the next versions we will deprecate the old output once most of our consumers adjust the new output

yoavrotems avatar Nov 14 '21 14:11 yoavrotems

Before I'm reviewing those new changes, we talked about it with some kube-bench users, and those changes are breaking the output for automation and other projects using kube-bench so lets do it for now as a flag, for example --enhancedoutput, and then it will be default to true, and if someone needs backward compatibility they could run it as ./kube-bench --enhancedoutput=false . It's important to say that this output with more status will be the default, and returning to the old status will have to be specifically chosen. It will be part of 0.7.0 and in the next versions we will deprecate the old output once most of our consumers adjust the new output

@hypnoglow Hi, Igor, Are you still working on this?

mozillazg avatar Feb 23 '22 11:02 mozillazg