docker-bench icon indicating copy to clipboard operation
docker-bench copied to clipboard

Add cis 1.6.0 from recent benchmark document

Open cesan3 opened this issue 1 year ago • 1 comments

Hi. I'm currently using your very nice tool and I noticed that it was still using benchmark checks against 1.3.1 for current docker version 20.10.20+. I wanted to create the configuration for 1.6.0, to bring it up to date. I also found very useful to lint the yaml files, so I added .pre-commit configuration file and some linters that are helpful to get the files cleaned-up. Not sure you're going to be ok with this, but It's good practice. The developers just need to install pre-commit on their local fork and they'll benefit from it.

The linters also suggested some cleanup to the golang code, so I added it as well.

Cheers

cesan3 avatar Nov 13 '23 02:11 cesan3

Hey @cesan3 Thanks for your recent contribution to the CIS 1.6.0 benchmarks in docker-bench. While your changes were appreciated, we've updated the benchmarks to align with the latest standards as per version 1.6.0 since 1.6.0 is an upgrdate to 1.3.1 but it is not a new docker cis profile. You can find the revised benchmarks in PR #124.

Your effort and dedication to the project are valued, and we encourage you to continue contributing.

KiranBodipi avatar Apr 03 '24 13:04 KiranBodipi