cloudsploit icon indicating copy to clipboard operation
cloudsploit copied to clipboard

936: Allow Multi-Valued Conditions in IAM Policies

Open chrisoverzero opened this issue 3 years ago • 3 comments

The code here assumed that any condition value must be a string, but condition values may also be arrays. The regex tests succeed in many cases because the array stringifies to a comma-delimited list of its elements, but this also means that only the first element is checked, effectively. When the array-of-arrays is passed back to, say, sqsCrossAccount, the includes test works, but not in the way which the author intended. This causes false negatives.

Resolves: #936

chrisoverzero avatar Dec 16 '21 22:12 chrisoverzero

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 16 '21 22:12 CLAassistant

Viewing this diff while ignoring whitespace differences will better illustrate how small this change truly is.

chrisoverzero avatar Jan 10 '22 17:01 chrisoverzero

Looks as though this was fixed for SQS in #991. I don't know if there's any interest in what I think is a more complete solution. If not, please do feel free to close this.

chrisoverzero avatar Jan 14 '22 17:01 chrisoverzero