Alex Pyrgiotis

Results 325 comments of Alex Pyrgiotis

> I'm not sure that's actually always the case; it depends on which UID/GID the adduser/addgroup commands use during the image building process. Now that they no longer have an...

I've made some [fixes](https://github.com/freedomofpress/dangerzone/commit/d480ca52f65a84c266d798794fd675774e67f447) to another branch of mine (see [`wip-gvisor-2`](https://github.com/freedomofpress/dangerzone/tree/wip-gvisor-2)), to make the code work for the second phase as well, and make it suitable for our various Linux...

I think I've made the PR work in every platform (~haven't tested on Windows yet~ edit: just did and it works :partying_face: ). I've made some [extra fixes](https://github.com/freedomofpress/dangerzone/commit/673e3ce657bc3685616f27a5b7f166b6a5a60986) in my...

Hi @EtiennePerot :wave:. From my side, I think we're in a position where we can finally merge the gVisor PR (see [`wip-gvisor-2`](https://github.com/freedomofpress/dangerzone/tree/wip-gvisor-2) branch) and the [corresponding design document](https://github.com/freedomofpress/dangerzone/pull/815), with some...

Oh, one more thing for when you have time. I was under the impression that gVisor was using a more modern approach to `ptrace()` called `systrap`. However, I'm not sure...

One other way that improper error handling bites us is when the container image is corrupted (possible only on dev environments). How to reproduce: 1. Create an invalid `tar` file...

Another dev has recently bumped into this issue (see https://github.com/freedomofpress/dangerzone/issues/883), which means we should prioritize it. After all, it's not that much work. Adding it tentatively in the 0.8.0 milestone...

Oh, very good observation! Yes, I think we could set the minimum Python3 version in our build instructions to >= 3.9 ([currently set](https://github.com/freedomofpress/dangerzone/blob/7c4e62954f4ee71726de0a23655c8f791f05f290/stdeb.cfg#L6) to 3.6 :bangbang:) . This way, the...

This issue has been resolved by the following PRs: * https://github.com/freedomofpress/dangerzone/pull/820 * https://github.com/freedomofpress/dangerzone/pull/818

That's an interesting case. We can't move the file the symlink points to, since another symlink may point to that as well. On the other hand, it doesn't make sense...