aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Feature Request]rocksdb multi_get improve read performance

Open nkysg opened this issue 2 years ago • 1 comments

🚀 Feature Request

Motivation

There are some places it can use rocksdb multi_get improve read performance, like https://github.com/aptos-labs/aptos-core/blob/main/storage/accumulator/src/lib.rs#L350

  fn get_hashes(&self, positions: &[Position]) -> Result<Vec<HashValue>> {
        positions.iter().map(|p| self.get_hash(*p)).collect()
    }

It use a for loop.It may be can use rocksdb multi_get improve read performance, may be other places also can use.

Is your feature request related to a problem? Please describe.

Pitch

Describe the solution you'd like

use rocksdb multi_get Describe alternatives you've considered

Are you willing to open a pull request? (See CONTRIBUTING) Yes

Additional context

nkysg avatar Apr 29 '22 20:04 nkysg

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] avatar Nov 07 '22 06:11 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] avatar Dec 24 '22 01:12 github-actions[bot]

Closing as there's no immediate action planned on this topic.

msmouse avatar Jan 05 '23 00:01 msmouse