aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[framework] Fee distribution for genesis

Open georgemitenkov opened this issue 2 years ago • 4 comments

Description

This PR enables fee distribution in genesis (currently with 100% burn percentage, so the behaviour should not change).

Test Plan

georgemitenkov avatar Jan 25 '23 15:01 georgemitenkov

Forge is running suite land_blocking on 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa

github-actions[bot] avatar Jan 25 '23 16:01 github-actions[bot]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa

github-actions[bot] avatar Jan 25 '23 16:01 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa

performance benchmark with full nodes : 6490 TPS, 6111 ms latency, 10200 ms p99 latency,(!) expired 340 out of 2771760 txns
Test Ok

github-actions[bot] avatar Jan 25 '23 16:01 github-actions[bot]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 8022 TPS, 4743 ms latency, 7300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa
compatibility::simple-validator-upgrade::single-validator-upgrade : 4638 TPS, 8435 ms latency, 11300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa
compatibility::simple-validator-upgrade::half-validator-upgrade : 4978 TPS, 8131 ms latency, 10100 ms p99 latency,no expired txns
4. upgrading second batch to new version: 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6880 TPS, 5488 ms latency, 10500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2a3c8c509b49e4e71ee428afa5a783c6cd5513aa passed
Test Ok

github-actions[bot] avatar Jan 25 '23 16:01 github-actions[bot]

How would we enable this in mainnet or testnet if we have to do the same thing? Ideally we should do the same flow here.

davidiw avatar Jan 28 '23 18:01 davidiw

How would we enable this in mainnet or testnet if we have to do the same thing? Ideally we should do the same flow here.

I think the idea is to test this in devnet first. Testnet would be much later as we’re still discussing combining this with quorum store incentives. We can apply proposals to turn feature flags on in devnet but it’s currently more manual work than potentially worth it (since devnet is reset every week). We’d need to turn on the flag once a week 😂

movekevin avatar Jan 29 '23 02:01 movekevin

You just specify in the vm-genesis.rs which feature flags are enabled. So -- more push back.

davidiw avatar Jan 29 '23 02:01 davidiw