aptos-core
aptos-core copied to clipboard

Published 20 hours ago •

Reame
Issues

[framework] Functions to get signer capability info. of an account.

Open vivekascoder opened this issue 2 years ago • 4 comments

Description

Added functions to get info about the signer capability of an address.

Test Plan

Should I add tests for these?

Jan 14 '23 19:01 vivekascoder

#6198

Jan 14 '23 20:01 vivekascoder

seems reasonable, but you need to run a few commands to generate files... whether that be building the node itself cargo build -p aptos-node or running pre-commit

e.g.

If you are seeing this message in CI, reproduce locally with: pre-commit run --all-files. To run pre-commit as part of git workflow, use pre-commit install.

Jan 14 '23 21:01 davidiw

lgtm but could you add 1-2 simple unit tests?

Jan 18 '23 23:01 0xchloe

Done @movekevin

Jan 21 '23 07:01 vivekascoder

Forge is running suite `land_blocking` on `c3c41d192659e83316c93dd5561c42b43cd394e2`

Feb 07 '23 14:02 github-actions[bot]

Forge is running suite `compat` on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `c3c41d192659e83316c93dd5561c42b43cd394e2`

Feb 07 '23 14:02 github-actions[bot]

:white_check_mark: Forge suite `land_blocking` success on `c3c41d192659e83316c93dd5561c42b43cd394e2`

performance benchmark with full nodes : 6447 TPS, 6154 ms latency, 9800 ms p99 latency,no expired txns
Test Ok

Feb 07 '23 15:02 github-actions[bot]

:white_check_mark: Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `c3c41d192659e83316c93dd5561c42b43cd394e2`

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c3c41d192659e83316c93dd5561c42b43cd394e2 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7453 TPS, 5213 ms latency, 7800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: c3c41d192659e83316c93dd5561c42b43cd394e2
compatibility::simple-validator-upgrade::single-validator-upgrade : 4677 TPS, 9022 ms latency, 12500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: c3c41d192659e83316c93dd5561c42b43cd394e2
compatibility::simple-validator-upgrade::half-validator-upgrade : 4360 TPS, 9131 ms latency, 12600 ms p99 latency,no expired txns
4. upgrading second batch to new version: c3c41d192659e83316c93dd5561c42b43cd394e2
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6382 TPS, 6011 ms latency, 9300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> c3c41d192659e83316c93dd5561c42b43cd394e2 passed
Test Ok

Feb 07 '23 15:02 github-actions[bot]

Forge is running suite `land_blocking` on `b1f3a411606f5440f84b2d9c211f76496e57895d`

Feb 23 '23 08:02 github-actions[bot]

Forge is running suite `framework_upgrade` on `cb4ba0a57c998c60cbab65af31a64875d2588ca5` ==> `b1f3a411606f5440f84b2d9c211f76496e57895d`

Feb 23 '23 08:02 github-actions[bot]

Forge is running suite `compat` on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `b1f3a411606f5440f84b2d9c211f76496e57895d`

Feb 23 '23 08:02 github-actions[bot]

:white_check_mark: Forge suite `land_blocking` success on `b1f3a411606f5440f84b2d9c211f76496e57895d`

performance benchmark with full nodes : 5728 TPS, 6922 ms latency, 16500 ms p99 latency,(!) expired 720 out of 2446660 txns
Test Ok

Feb 23 '23 08:02 github-actions[bot]

:white_check_mark: Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `b1f3a411606f5440f84b2d9c211f76496e57895d`

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b1f3a411606f5440f84b2d9c211f76496e57895d (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 8088 TPS, 4689 ms latency, 7300 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: b1f3a411606f5440f84b2d9c211f76496e57895d
compatibility::simple-validator-upgrade::single-validator-upgrade : 5075 TPS, 7856 ms latency, 11100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: b1f3a411606f5440f84b2d9c211f76496e57895d
compatibility::simple-validator-upgrade::half-validator-upgrade : 4903 TPS, 7824 ms latency, 10100 ms p99 latency,no expired txns
4. upgrading second batch to new version: b1f3a411606f5440f84b2d9c211f76496e57895d
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6679 TPS, 5723 ms latency, 10300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> b1f3a411606f5440f84b2d9c211f76496e57895d passed
Test Ok

Feb 23 '23 08:02 github-actions[bot]

:white_check_mark: Forge suite `framework_upgrade` success on `cb4ba0a57c998c60cbab65af31a64875d2588ca5` ==> `b1f3a411606f5440f84b2d9c211f76496e57895d`

Compatibility test results for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b1f3a411606f5440f84b2d9c211f76496e57895d (PR)
Upgrade the nodes to version: b1f3a411606f5440f84b2d9c211f76496e57895d
framework_upgrade::framework-upgrade::full-framework-upgrade : 6650 TPS, 5740 ms latency, 8100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for cb4ba0a57c998c60cbab65af31a64875d2588ca5 ==> b1f3a411606f5440f84b2d9c211f76496e57895d passed
Test Ok

Feb 23 '23 08:02 github-actions[bot]