[gas] consolidate storage charges and makes things configurable

[msmouse]

Description

Test Plan

---

This change is 

[github-actions[bot]]

Forge is running suite land_blocking on dda040a5bfc8e24c9f43dc2a994df064f7f27258

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dda040a5bfc8e24c9f43dc2a994df064f7f27258

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:x: Forge suite compat failure on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dda040a5bfc8e24c9f43dc2a994df064f7f27258

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dda040a5bfc8e24c9f43dc2a994df064f7f27258 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7644 TPS, 5178 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: dda040a5bfc8e24c9f43dc2a994df064f7f27258
Test Failed: Retry due to pod aptos-node-1-validator-0 status PodStatus { conditions: Some([PodCondition { last_probe_time: None, last_transition_time: Some(Time(2022-11-15T17:07:32Z)), message: Some("0/36 nodes are available: 36 Insufficient cpu, 36 Insufficient memory."), reason: Some("Unschedulable"), status: "False", type_: "PodScheduled" }]), container_statuses: None, host_ip: None, init_container_statuses: None, message: None, nominated_node_name: None, phase: Some("Pending"), pod_ip: None, qos_class: Some("Guaranteed"), reason: None, start_time: None }
Trailing Log Lines:
::error::Retry due to pod aptos-node-1-validator-0 status PodStatus { conditions: Some([PodCondition { last_probe_time: None, last_transition_time: Some(Time(2022-11-15T17:07:32Z)), message: Some("0/36 nodes are available: 36 Insufficient cpu, 36 Insufficient memory."), reason: Some("Unschedulable"), status: "False", type_: "PodScheduled" }]), container_statuses: None, host_ip: None, init_container_statuses: None, message: None, nominated_node_name: None, phase: Some("Pending"), pod_ip: None, qos_class: Some("Guaranteed"), reason: None, start_time: None }
test compatibility::simple-validator-upgrade ... FAILED
Error: Retry due to pod aptos-node-1-validator-0 status PodStatus { conditions: Some([PodCondition { last_probe_time: None, last_transition_time: Some(Time(2022-11-15T17:07:32Z)), message: Some("0/36 nodes are available: 36 Insufficient cpu, 36 Insufficient memory."), reason: Some("Unschedulable"), status: "False", type_: "PodScheduled" }]), container_statuses: None, host_ip: None, init_container_statuses: None, message: None, nominated_node_name: None, phase: Some("Pending"), pod_ip: None, qos_class: Some("Guaranteed"), reason: None, start_time: None }
Test Statistics: 
Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> dda040a5bfc8e24c9f43dc2a994df064f7f27258 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7644 TPS, 5178 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: dda040a5bfc8e24c9f43dc2a994df064f7f27258
Test Failed: Retry due to pod aptos-node-1-validator-0 status PodStatus { conditions: Some([PodCondition { last_probe_time: None, last_transition_time: Some(Time(2022-11-15T17:07:32Z)), message: Some("0/36 nodes are available: 36 Insufficient cpu, 36 Insufficient memory."), reason: Some("Unschedulable"), status: "False", type_: "PodScheduled" }]), container_statuses: None, host_ip: None, init_container_statuses: None, message: None, nominated_node_name: None, phase: Some("Pending"), pod_ip: None, qos_class: Some("Guaranteed"), reason: None, start_time: None }


Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:280"},"thread_name":"main","hostname":"forge-compat-pr-5566-1668531686-testnet-2d8b1b57553d869190f61df","timestamp":"2022-11-15T17:12:33.355704Z","message":"Deleting namespace forge-compat-pr-5566: Some(NamespaceStatus { phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:388"},"thread_name":"main","hostname":"forge-compat-pr-5566-1668531686-testnet-2d8b1b57553d869190f61df","timestamp":"2022-11-15T17:12:33.358692Z","message":"aptos-node resources for Forge removed in namespace: forge-compat-pr-5566"}

failures:
    compatibility::simple-validator-upgrade

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed
Debugging output:
NAME                                   READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0               1/1     Running     0          10m
aptos-node-1-validator-0               0/1     Pending     0          5m7s
aptos-node-2-validator-0               1/1     Running     0          10m
aptos-node-3-validator-0               1/1     Running     0          10m
aptos-node-4-validator-0               1/1     Running     0          10m
genesis-aptos-genesis-eforge63-66755   0/1     Completed   0          10m

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite land_blocking success on dda040a5bfc8e24c9f43dc2a994df064f7f27258

performance benchmark with full nodes : 6433 TPS, 6118 ms latency, 21600 ms p99 latency,(!) expired 5381 out of 2752600 txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite land_blocking on d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite land_blocking success on d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d

performance benchmark with full nodes : 6815 TPS, 5795 ms latency, 25300 ms p99 latency,(!) expired 1160 out of 2911540 txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7466 TPS, 5201 ms latency, 8400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d
compatibility::simple-validator-upgrade::single-validator-upgrade : 5008 TPS, 8307 ms latency, 10500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d
compatibility::simple-validator-upgrade::half-validator-upgrade : 4440 TPS, 9108 ms latency, 12500 ms p99 latency,no expired txns
4. upgrading second batch to new version: d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6967 TPS, 5491 ms latency, 9400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d75b358f67c2a3cf0a9e13f60cb6844dc8b9d57d passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite land_blocking on d7ecd86aa991a89db8db33be9310135c412a287a

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d7ecd86aa991a89db8db33be9310135c412a287a

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d7ecd86aa991a89db8db33be9310135c412a287a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d7ecd86aa991a89db8db33be9310135c412a287a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7374 TPS, 5353 ms latency, 7600 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: d7ecd86aa991a89db8db33be9310135c412a287a
compatibility::simple-validator-upgrade::single-validator-upgrade : 4741 TPS, 8418 ms latency, 10900 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: d7ecd86aa991a89db8db33be9310135c412a287a
compatibility::simple-validator-upgrade::half-validator-upgrade : 4577 TPS, 8909 ms latency, 11700 ms p99 latency,no expired txns
4. upgrading second batch to new version: d7ecd86aa991a89db8db33be9310135c412a287a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6684 TPS, 5801 ms latency, 10300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d7ecd86aa991a89db8db33be9310135c412a287a passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite land_blocking success on d7ecd86aa991a89db8db33be9310135c412a287a

performance benchmark with full nodes : 6940 TPS, 5710 ms latency, 10200 ms p99 latency,(!) expired 520 out of 2964300 txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e7fc5345670d0e45365922a5edaada9ac50959a9

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite land_blocking on e7fc5345670d0e45365922a5edaada9ac50959a9

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite land_blocking success on e7fc5345670d0e45365922a5edaada9ac50959a9

performance benchmark with full nodes : 6400 TPS, 6216 ms latency, 21400 ms p99 latency,(!) expired 80 out of 2732880 txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e7fc5345670d0e45365922a5edaada9ac50959a9

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e7fc5345670d0e45365922a5edaada9ac50959a9 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7184 TPS, 5408 ms latency, 7000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: e7fc5345670d0e45365922a5edaada9ac50959a9
compatibility::simple-validator-upgrade::single-validator-upgrade : 4745 TPS, 8824 ms latency, 11600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: e7fc5345670d0e45365922a5edaada9ac50959a9
compatibility::simple-validator-upgrade::half-validator-upgrade : 4765 TPS, 8619 ms latency, 10300 ms p99 latency,no expired txns
4. upgrading second batch to new version: e7fc5345670d0e45365922a5edaada9ac50959a9
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6529 TPS, 5834 ms latency, 9400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> e7fc5345670d0e45365922a5edaada9ac50959a9 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[msmouse]

Rebased and converted from &dyn to enum for performance as suggested by @vgao1996

Converting to draft before other adjustments.

[github-actions[bot]]

Forge is running suite land_blocking on d546bc6d1fab7cbddbe9f198fc2512ba541cfd95

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d546bc6d1fab7cbddbe9f198fc2512ba541cfd95

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d546bc6d1fab7cbddbe9f198fc2512ba541cfd95

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d546bc6d1fab7cbddbe9f198fc2512ba541cfd95 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 6947 TPS, 5594 ms latency, 10200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: d546bc6d1fab7cbddbe9f198fc2512ba541cfd95
compatibility::simple-validator-upgrade::single-validator-upgrade : 4412 TPS, 9240 ms latency, 11900 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: d546bc6d1fab7cbddbe9f198fc2512ba541cfd95
compatibility::simple-validator-upgrade::half-validator-upgrade : 4719 TPS, 8718 ms latency, 11600 ms p99 latency,no expired txns
4. upgrading second batch to new version: d546bc6d1fab7cbddbe9f198fc2512ba541cfd95
compatibility::simple-validator-upgrade::rest-validator-upgrade : 5494 TPS, 7041 ms latency, 13300 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> d546bc6d1fab7cbddbe9f198fc2512ba541cfd95 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite land_blocking success on d546bc6d1fab7cbddbe9f198fc2512ba541cfd95

performance benchmark with full nodes : 6569 TPS, 6029 ms latency, 11000 ms p99 latency,no expired txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[msmouse]

Now I create a trait CheckChangeSet in types so the implementation can be in aptos-gas, hence the "builder" is gone.

[github-actions[bot]]

Forge is running suite land_blocking on 54e19f95802d348b4e6628ba2054aca86877018e

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 54e19f95802d348b4e6628ba2054aca86877018e

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite land_blocking success on 54e19f95802d348b4e6628ba2054aca86877018e

performance benchmark with full nodes : 6830 TPS, 5811 ms latency, 8100 ms p99 latency,no expired txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 54e19f95802d348b4e6628ba2054aca86877018e

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 54e19f95802d348b4e6628ba2054aca86877018e (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7804 TPS, 4961 ms latency, 6400 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 54e19f95802d348b4e6628ba2054aca86877018e
compatibility::simple-validator-upgrade::single-validator-upgrade : 4547 TPS, 9117 ms latency, 12300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 54e19f95802d348b4e6628ba2054aca86877018e
compatibility::simple-validator-upgrade::half-validator-upgrade : 4786 TPS, 8617 ms latency, 12100 ms p99 latency,no expired txns
4. upgrading second batch to new version: 54e19f95802d348b4e6628ba2054aca86877018e
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7030 TPS, 5672 ms latency, 11900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 54e19f95802d348b4e6628ba2054aca86877018e passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite land_blocking on 9cce851165352c3d0094eb73cec2771248b5714f

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9cce851165352c3d0094eb73cec2771248b5714f

• Grafana dashboard (auto-refresh)
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite land_blocking success on 9cce851165352c3d0094eb73cec2771248b5714f

performance benchmark with full nodes : 6429 TPS, 6185 ms latency, 9600 ms p99 latency,no expired txns
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9cce851165352c3d0094eb73cec2771248b5714f

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9cce851165352c3d0094eb73cec2771248b5714f (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7438 TPS, 5285 ms latency, 8200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 9cce851165352c3d0094eb73cec2771248b5714f
compatibility::simple-validator-upgrade::single-validator-upgrade : 4476 TPS, 9097 ms latency, 11300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 9cce851165352c3d0094eb73cec2771248b5714f
compatibility::simple-validator-upgrade::half-validator-upgrade : 4532 TPS, 8780 ms latency, 12500 ms p99 latency,no expired txns
4. upgrading second batch to new version: 9cce851165352c3d0094eb73cec2771248b5714f
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6182 TPS, 6271 ms latency, 10600 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9cce851165352c3d0094eb73cec2771248b5714f passed
Test Ok

• Grafana dashboard
• Humio Logs
• Test runner output
• Test run is land-blocking