aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

Use pnpm for the dev docs site

Open banool opened this issue 3 years ago • 7 comments

Description

We're experimenting with moving to pnpm over yarn: https://aptos-org.slack.com/archives/C03N83P7QUC/p1667514786627619. Starting from the top with the dev docs site.

I used pnpm import.

Test Plan

I tested locally, now we check to see that netlify builds.


This change is Reviewable

banool avatar Nov 03 '22 23:11 banool

@clay-aptos Interested in your thoughts on this. For context, we're trying to move from yarn to pnpm. All this means to you is you use pnpm instead of yarn, it is a drop in replacement. So pnpm start instead of yarn start for example.

banool avatar Nov 03 '22 23:11 banool

@clay-aptos Interested in your thoughts on this. For context, we're trying to move from yarn to pnpm. All this means to you is you use pnpm instead of yarn, it is a drop in replacement. So pnpm start instead of yarn start for example.

I'm fine with this assuming we can test thoroughly. I recall when Christian enabled pnpm globally a few weeks ago it broke docs builds. I assume your change would address that, so please proceed and simply let me know when done. I will update our README to reflect the change: https://github.com/aptos-labs/aptos-core/blob/main/developer-docs-site/README.md

Thanks for including me!

clay-aptos avatar Nov 03 '22 23:11 clay-aptos

This should not cause the same issue as a few weeks ago, but I'll test thoroughly 👍

banool avatar Nov 03 '22 23:11 banool

Forge is running suite compat on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc

github-actions[bot] avatar Nov 04 '22 17:11 github-actions[bot]

Forge is running suite land_blocking on 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc

github-actions[bot] avatar Nov 04 '22 17:11 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc

performance benchmark with full nodes : 6618 TPS, 5978 ms latency, 22000 ms p99 latency,(!) expired 3234 out of 2829500 txns
Test Ok

github-actions[bot] avatar Nov 04 '22 17:11 github-actions[bot]

:white_check_mark: Forge suite compat success on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc

Compatibility test results for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc (PR)
1. Check liveness of validators at old version: 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7439 TPS, 5368 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc
compatibility::simple-validator-upgrade::single-validator-upgrade : 4563 TPS, 9049 ms latency, 11800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc
compatibility::simple-validator-upgrade::half-validator-upgrade : 4626 TPS, 8695 ms latency, 12000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6552 TPS, 5910 ms latency, 10400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 6a1d45ad771b429845ab18b2166cec9c7bb6d0cc passed
Test Ok

github-actions[bot] avatar Nov 04 '22 17:11 github-actions[bot]

Forge is running suite compat on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0a37e81e933baa714b770e67118e07cad7e95c6d

github-actions[bot] avatar Nov 04 '22 18:11 github-actions[bot]

Forge is running suite land_blocking on 0a37e81e933baa714b770e67118e07cad7e95c6d

github-actions[bot] avatar Nov 04 '22 18:11 github-actions[bot]

:white_check_mark: Forge suite compat success on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0a37e81e933baa714b770e67118e07cad7e95c6d

Compatibility test results for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0a37e81e933baa714b770e67118e07cad7e95c6d (PR)
1. Check liveness of validators at old version: 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7449 TPS, 5134 ms latency, 7200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 0a37e81e933baa714b770e67118e07cad7e95c6d
compatibility::simple-validator-upgrade::single-validator-upgrade : 4678 TPS, 8764 ms latency, 11600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 0a37e81e933baa714b770e67118e07cad7e95c6d
compatibility::simple-validator-upgrade::half-validator-upgrade : 4553 TPS, 8837 ms latency, 11800 ms p99 latency,no expired txns
4. upgrading second batch to new version: 0a37e81e933baa714b770e67118e07cad7e95c6d
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6650 TPS, 5717 ms latency, 9700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0a37e81e933baa714b770e67118e07cad7e95c6d passed
Test Ok

github-actions[bot] avatar Nov 04 '22 18:11 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 0a37e81e933baa714b770e67118e07cad7e95c6d

performance benchmark with full nodes : 6401 TPS, 6212 ms latency, 14800 ms p99 latency,(!) expired 246 out of 2733560 txns
Test Ok

github-actions[bot] avatar Nov 04 '22 18:11 github-actions[bot]