aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[TS][SDK] Use pagination in getAccountResources and getAccountModules

Open banool opened this issue 3 years ago • 9 comments

Description

This PR makes getAccountResources and getAccountModules use pagination, leveraging the support added in https://github.com/aptos-labs/aptos-core/pull/5313.

Test Plan

I ran the below tests both against a local node built from main and prod devnet, to ensure compatibility with both.

Run the SDK tests:

yarn test

This change is Reviewable

banool avatar Nov 02 '22 00:11 banool

Forge is running suite land_blocking on 4a717df198be875ca6b30736b0e3397c5cee349e

github-actions[bot] avatar Nov 03 '22 21:11 github-actions[bot]

Forge is running suite compat on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4a717df198be875ca6b30736b0e3397c5cee349e

github-actions[bot] avatar Nov 03 '22 21:11 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 4a717df198be875ca6b30736b0e3397c5cee349e

performance benchmark with full nodes : 6826 TPS, 5831 ms latency, 20500 ms p99 latency,no expired txns
Test Ok

github-actions[bot] avatar Nov 03 '22 22:11 github-actions[bot]

:white_check_mark: Forge suite compat success on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4a717df198be875ca6b30736b0e3397c5cee349e

Compatibility test results for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4a717df198be875ca6b30736b0e3397c5cee349e (PR)
1. Check liveness of validators at old version: 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7470 TPS, 5177 ms latency, 6600 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 4a717df198be875ca6b30736b0e3397c5cee349e
compatibility::simple-validator-upgrade::single-validator-upgrade : 4641 TPS, 8742 ms latency, 11500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 4a717df198be875ca6b30736b0e3397c5cee349e
compatibility::simple-validator-upgrade::half-validator-upgrade : 4868 TPS, 7989 ms latency, 12100 ms p99 latency,no expired txns
4. upgrading second batch to new version: 4a717df198be875ca6b30736b0e3397c5cee349e
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6914 TPS, 5665 ms latency, 10900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4a717df198be875ca6b30736b0e3397c5cee349e passed
Test Ok

github-actions[bot] avatar Nov 03 '22 22:11 github-actions[bot]

Landing https://github.com/aptos-labs/aptos-core/pull/5443 first.

banool avatar Nov 04 '22 00:11 banool

Forge is running suite compat on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe

github-actions[bot] avatar Nov 04 '22 16:11 github-actions[bot]

Forge is running suite land_blocking on 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe

github-actions[bot] avatar Nov 04 '22 16:11 github-actions[bot]

:white_check_mark: Forge suite compat success on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe

Compatibility test results for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe (PR)
1. Check liveness of validators at old version: 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7401 TPS, 5377 ms latency, 7500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe
compatibility::simple-validator-upgrade::single-validator-upgrade : 4722 TPS, 8584 ms latency, 11800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe
compatibility::simple-validator-upgrade::half-validator-upgrade : 4409 TPS, 9472 ms latency, 13000 ms p99 latency,no expired txns
4. upgrading second batch to new version: 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6908 TPS, 5611 ms latency, 9500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe passed
Test Ok

github-actions[bot] avatar Nov 04 '22 16:11 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 0e506288d6f3f38d0a70e1556d32239f4ac5e0fe

performance benchmark with full nodes : 6876 TPS, 5751 ms latency, 16500 ms p99 latency,(!) expired 1448 out of 2937720 txns
Test Ok

github-actions[bot] avatar Nov 04 '22 16:11 github-actions[bot]

Forge is running suite land_blocking on 9dbcf6b8ffd16a92ea3928d0b311684895e7965c

github-actions[bot] avatar Nov 04 '22 19:11 github-actions[bot]

Forge is running suite compat on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9dbcf6b8ffd16a92ea3928d0b311684895e7965c

github-actions[bot] avatar Nov 04 '22 19:11 github-actions[bot]

:white_check_mark: Forge suite compat success on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9dbcf6b8ffd16a92ea3928d0b311684895e7965c

Compatibility test results for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9dbcf6b8ffd16a92ea3928d0b311684895e7965c (PR)
1. Check liveness of validators at old version: 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7385 TPS, 5314 ms latency, 7500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 9dbcf6b8ffd16a92ea3928d0b311684895e7965c
compatibility::simple-validator-upgrade::single-validator-upgrade : 4310 TPS, 9190 ms latency, 12200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 9dbcf6b8ffd16a92ea3928d0b311684895e7965c
compatibility::simple-validator-upgrade::half-validator-upgrade : 4834 TPS, 8343 ms latency, 11400 ms p99 latency,no expired txns
4. upgrading second batch to new version: 9dbcf6b8ffd16a92ea3928d0b311684895e7965c
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6794 TPS, 5686 ms latency, 10700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 9dbcf6b8ffd16a92ea3928d0b311684895e7965c passed
Test Ok

github-actions[bot] avatar Nov 04 '22 19:11 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 9dbcf6b8ffd16a92ea3928d0b311684895e7965c

performance benchmark with full nodes : 6933 TPS, 5728 ms latency, 7200 ms p99 latency,no expired txns
Test Ok

github-actions[bot] avatar Nov 04 '22 20:11 github-actions[bot]

Forge is running suite land_blocking on 36818dad663ca3d2cd087db8d8f5aceb8e291cc9

github-actions[bot] avatar Nov 04 '22 21:11 github-actions[bot]

Forge is running suite compat on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 36818dad663ca3d2cd087db8d8f5aceb8e291cc9

github-actions[bot] avatar Nov 04 '22 21:11 github-actions[bot]

:white_check_mark: Forge suite compat success on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 36818dad663ca3d2cd087db8d8f5aceb8e291cc9

Compatibility test results for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 36818dad663ca3d2cd087db8d8f5aceb8e291cc9 (PR)
1. Check liveness of validators at old version: 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7536 TPS, 5155 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 36818dad663ca3d2cd087db8d8f5aceb8e291cc9
compatibility::simple-validator-upgrade::single-validator-upgrade : 4952 TPS, 8303 ms latency, 11400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 36818dad663ca3d2cd087db8d8f5aceb8e291cc9
compatibility::simple-validator-upgrade::half-validator-upgrade : 4706 TPS, 8699 ms latency, 10900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 36818dad663ca3d2cd087db8d8f5aceb8e291cc9
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6945 TPS, 5703 ms latency, 9900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 36818dad663ca3d2cd087db8d8f5aceb8e291cc9 passed
Test Ok

github-actions[bot] avatar Nov 04 '22 21:11 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 36818dad663ca3d2cd087db8d8f5aceb8e291cc9

performance benchmark with full nodes : 6739 TPS, 5926 ms latency, 14100 ms p99 latency,(!) expired 1844 out of 2879420 txns
Test Ok

github-actions[bot] avatar Nov 04 '22 21:11 github-actions[bot]

https://www.npmjs.com/package/aptos aptos 1.3.16

When is Aptos SDK updated to repair this bug, this is really important for developers

guijunchen avatar Nov 08 '22 10:11 guijunchen