aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Feature Request] Improve Upgradability documentation

Open movekevin opened this issue 3 years ago • 20 comments
trafficstars

  1. Let's merge https://aptos.dev/guides/move-guides/upgrading-move-code into the Move book, now that it's been ported over to aptos-core thanks to @wrwg
  2. We should add more examples and may be create a tutorial either in the Move book or aptos.dev for upgrading modules (what devs can do or can't do)

movekevin avatar Nov 01 '22 17:11 movekevin

Thanks, @movekevin! I assume I will work with you directly. If not, please co-assign the respective source (expert) for this. Thanks again!

clay-aptos avatar Nov 01 '22 18:11 clay-aptos

I think the definition of compatibility belongs into the code module and then should be linked from the guide. (It is a guide not reference.)

wrwg avatar Nov 01 '22 19:11 wrwg

Giving this a low priority until we get some movement from @movekevin .

clay-aptos avatar Dec 07 '22 20:12 clay-aptos

Per Move Workshop #2: Few smart contracts should be immutable, namely simple libraries. Upgrading can be difficult, requiring migrating users from the old smart contract to the new. This can be mitigated by modular design.

clay-aptos avatar Jan 10 '23 00:01 clay-aptos

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] avatar Feb 25 '23 02:02 github-actions[bot]

Hi @movekevin , who can I work with to get answers to questions you posed when filing this issue? Thanks!

clay-aptos avatar Feb 27 '23 18:02 clay-aptos

I've added a lot of these already in the Move book. The next step I think is to write a thorough tutorial on upgrading move tutorials that run through a lot of these rules to make them clear/easier to follow.

movekevin avatar Feb 27 '23 19:02 movekevin

Thanks for asking Gerben to help, Kevin!

clay-aptos avatar Feb 27 '23 20:02 clay-aptos

Also move upgradability page into Aptos Move book, as we are with this.

wrwg avatar Mar 15 '23 23:03 wrwg

I've updated the description to reflect most recent developments (Move book being ported over) and related discussion

movekevin avatar Mar 15 '23 23:03 movekevin

Also move upgradability page into Aptos Move book, as we are with this.

Just confirming that should be done upstream in the aptos-main branch of the Move Lang repo still? https://github.com/move-language/move/tree/aptos-main/language/documentation/book

Thanks.

clay-aptos avatar Mar 16 '23 15:03 clay-aptos

Also move upgradability page into Aptos Move book, as we are with this.

Just confirming that should be done upstream in the aptos-main branch of the Move Lang repo still? https://github.com/move-language/move/tree/aptos-main/language/documentation/book

Thanks.

No. @wrwg already ported the Move book over into our repo

movekevin avatar Mar 16 '23 17:03 movekevin

Actually @clay-aptos did import it (on my ask), I worked on the tutorial. Clay why do you think we need to push upstream? Upgradability is aptos specific. I care together with the Move partners (weekly meetings) if there is anything to push upstream. There hasn't been any change in the shared Move language since 1 1/2 years.

wrwg avatar Mar 16 '23 17:03 wrwg

Actually @clay-aptos did import it (on my ask), I worked on the tutorial. Clay why do you think we need to push upstream? Upgradability is aptos specific. I care together with the Move partners (weekly meetings) if there is anything to push upstream. There hasn't been any change in the shared Move language since 1 1/2 years.

Ah, I thought you wanted to update the Move Book contents. And I thought those were maintained upstream and copied (manually by me the last time) from the Move Lang repo to ours. If this can go in our version and not be overwritten, please ignore me. Thanks!

clay-aptos avatar Mar 16 '23 18:03 clay-aptos

Here is a PR to migrate the existing upgradability doc into the Move Book: https://github.com/aptos-labs/aptos-core/pull/7346 as the first step to improving the upgradability documentation.

junkil-park avatar Mar 23 '23 20:03 junkil-park

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] avatar May 08 '23 01:05 github-actions[bot]

Assigning to @vusirikala who's working on some really cool tutorials for deploying and upgrading modules

movekevin avatar May 28 '23 16:05 movekevin

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jul 13 '23 02:07 github-actions[bot]