aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[API] Clarify which endpoints return committed / pending transactions

Open banool opened this issue 3 years ago • 1 comments

Description

In this PR I make it clearer which endpoints return transactions in which states.

I also remove a todo about /encode_submission. We shouldn't be encouraging people to use this endpoint, it is insecure.

Test Plan

👀


This change is Reviewable

banool avatar Oct 28 '22 21:10 banool

@clay-aptos feel free to take over from here if you want to make some changes!

banool avatar Oct 28 '22 21:10 banool

@clay-aptos feel free to take over from here if you want to make some changes!

Thanks, @banool ! I made some small edits directly in a commit here.

clay-aptos avatar Oct 31 '22 15:10 clay-aptos

Thanks, I'll make the changes to the code and regenerate accordingly.

banool avatar Oct 31 '22 16:10 banool

Thanks, I'll make the changes to the code and regenerate accordingly.

Here is the replacement: https://github.com/aptos-labs/aptos-core/pull/5376

clay-aptos avatar Oct 31 '22 22:10 clay-aptos