aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[ts-sdk] Add an isValid function for AccountAddress

Open gregnazario opened this issue 2 years ago • 4 comments

Description

Adds an isValid function

Test Plan


This change is Reviewable

gregnazario avatar Oct 18 '22 19:10 gregnazario

Forge is running suite compat on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2b4719206d5df7c6ca22aeea10cfba58782902b3

github-actions[bot] avatar Nov 05 '22 21:11 github-actions[bot]

Forge is running suite land_blocking on 2b4719206d5df7c6ca22aeea10cfba58782902b3

github-actions[bot] avatar Nov 05 '22 21:11 github-actions[bot]

:white_check_mark: Forge suite compat success on 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2b4719206d5df7c6ca22aeea10cfba58782902b3

Compatibility test results for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2b4719206d5df7c6ca22aeea10cfba58782902b3 (PR)
1. Check liveness of validators at old version: 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7478 TPS, 5163 ms latency, 7000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 2b4719206d5df7c6ca22aeea10cfba58782902b3
compatibility::simple-validator-upgrade::single-validator-upgrade : 4674 TPS, 8597 ms latency, 11500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 2b4719206d5df7c6ca22aeea10cfba58782902b3
compatibility::simple-validator-upgrade::half-validator-upgrade : 4624 TPS, 8831 ms latency, 11300 ms p99 latency,no expired txns
4. upgrading second batch to new version: 2b4719206d5df7c6ca22aeea10cfba58782902b3
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6536 TPS, 5864 ms latency, 9900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 2b4719206d5df7c6ca22aeea10cfba58782902b3 passed
Test Ok

github-actions[bot] avatar Nov 05 '22 21:11 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 2b4719206d5df7c6ca22aeea10cfba58782902b3

performance benchmark with full nodes : 6863 TPS, 5786 ms latency, 13000 ms p99 latency,no expired txns
Test Ok

github-actions[bot] avatar Nov 05 '22 21:11 github-actions[bot]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 27c397d6c7b1b0b5da836b02d83673118231ee7a

github-actions[bot] avatar Dec 09 '22 02:12 github-actions[bot]

Forge is running suite land_blocking on 27c397d6c7b1b0b5da836b02d83673118231ee7a

github-actions[bot] avatar Dec 09 '22 02:12 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 27c397d6c7b1b0b5da836b02d83673118231ee7a

performance benchmark with full nodes : 6342 TPS, 6231 ms latency, 12600 ms p99 latency,(!) expired 1040 out of 2709240 txns
Test Ok

github-actions[bot] avatar Dec 09 '22 02:12 github-actions[bot]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 27c397d6c7b1b0b5da836b02d83673118231ee7a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 27c397d6c7b1b0b5da836b02d83673118231ee7a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 6906 TPS, 5767 ms latency, 10100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 27c397d6c7b1b0b5da836b02d83673118231ee7a
compatibility::simple-validator-upgrade::single-validator-upgrade : 4678 TPS, 8547 ms latency, 11200 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 27c397d6c7b1b0b5da836b02d83673118231ee7a
compatibility::simple-validator-upgrade::half-validator-upgrade : 4588 TPS, 8804 ms latency, 11900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 27c397d6c7b1b0b5da836b02d83673118231ee7a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6618 TPS, 5933 ms latency, 10700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 27c397d6c7b1b0b5da836b02d83673118231ee7a passed
Test Ok

github-actions[bot] avatar Dec 09 '22 02:12 github-actions[bot]

Forge is running suite compat on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb

github-actions[bot] avatar Dec 28 '22 21:12 github-actions[bot]

Forge is running suite land_blocking on 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb

github-actions[bot] avatar Dec 28 '22 21:12 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb

performance benchmark with full nodes : 6682 TPS, 5948 ms latency, 8100 ms p99 latency,(!) expired 40 out of 2853520 txns
Test Ok

github-actions[bot] avatar Dec 28 '22 21:12 github-actions[bot]

:white_check_mark: Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7529 TPS, 5130 ms latency, 7500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb
compatibility::simple-validator-upgrade::single-validator-upgrade : 4596 TPS, 8926 ms latency, 11000 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb
compatibility::simple-validator-upgrade::half-validator-upgrade : 4412 TPS, 9217 ms latency, 12100 ms p99 latency,no expired txns
4. upgrading second batch to new version: 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6596 TPS, 5869 ms latency, 10800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 4dd3b0f81f2e1cbb48ab40d7ad0c09333b6d56eb passed
Test Ok

github-actions[bot] avatar Dec 28 '22 21:12 github-actions[bot]