aptos-core
aptos-core copied to clipboard
[consensus][e2e] Add e2e smoke test for changing onchain config and voting history fix
running locally with: LOCAL_SWARM_NODE_RELEASE=1 cargo test --release --package smoke-test --lib -- aptos_cli::validator::test_onchain_config_change --exact --nocapture
we get: With new config: 23 rounds from vote to elected: Some(20) to Some(43) With old config: 61 rounds from vote to elected: Some(12) to Some(73)
Yeah this is a smoke test for the (already committed) leader election onchain config change planned for next release.
What I think we need to be able to do, to have smoke tests for governance proposals like these (which we really should have - otherwise they are not continuously tested):
- be able to set genesis onchain config. This basically tests a revert, because genesis is now new. I'll try to add this to smoke tests
- wrappers for generating proposals like these, and executing governance - i.e. we shouldn't need every smoke test to implement that
- be able to set smoke-tests to run nightly. this tests for example runs for multiple minutes, so not great to have it run on every PR :/
I'll include the consensus config in the proposal generator!
Argh, I had these PRs stacked, merging this one doesn't merge in main @runtian-zhou .
since this PR is marked as merged, I needed to recreate it - #5594