aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

Add rust_lint.sh, use it in CI

Open banool opened this issue 2 years ago • 1 comments

Description

Long requested, much desired, finally here. Running this script will ensure that your PR passes the rust-lint step in CI.

Test Plan

scripts/rust_lint.sh
scripts/rust_lint.sh --check

This change is Reviewable

banool avatar Sep 14 '22 00:09 banool

We don't do all of this in pre-commit, just fmt. Running xclippy in pre-commit might not be desirable, it's pretty slow. Either way we can consider this in a separate PR.

banool avatar Sep 14 '22 15:09 banool

  • Changed it so it only verifies that you're at the root.
  • Added a link to a wrapper that lets you run it from anywhere in the repo.

banool avatar Sep 14 '22 15:09 banool

Forge is running suite land_blocking on b6fb7accc5ee0b2e579c556fc4df4739c9166115

Forge is running suite compat on testnet ==> b6fb7accc5ee0b2e579c556fc4df4739c9166115

:white_check_mark: Forge suite land_blocking success on b6fb7accc5ee0b2e579c556fc4df4739c9166115

performance benchmark with full nodes : 8086 TPS, 4904 ms latency, 8700 ms p99 latency,no expired txns
Test Ok

:white_check_mark: Forge suite compat success on testnet ==> b6fb7accc5ee0b2e579c556fc4df4739c9166115

Compatibility test results for testnet ==> b6fb7accc5ee0b2e579c556fc4df4739c9166115 (PR)
1. Check liveness of validators at old version: testnet
compatibility::simple-validator-upgrade::liveness-check : 7779 TPS, 4799 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: b6fb7accc5ee0b2e579c556fc4df4739c9166115
compatibility::simple-validator-upgrade::single-validator-upgrade : 5798 TPS, 6339 ms latency, 8600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: b6fb7accc5ee0b2e579c556fc4df4739c9166115
compatibility::simple-validator-upgrade::half-validator-upgrade : 5580 TPS, 7741 ms latency, 15700 ms p99 latency,no expired txns
4. upgrading second batch to new version: b6fb7accc5ee0b2e579c556fc4df4739c9166115
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7464 TPS, 4860 ms latency, 9100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet ==> b6fb7accc5ee0b2e579c556fc4df4739c9166115 passed
Test Ok

Forge is running suite compat on testnet ==> 558c9f34644c444d425ae033c534cfd35a4e7568

Forge is running suite land_blocking on 558c9f34644c444d425ae033c534cfd35a4e7568

:white_check_mark: Forge suite land_blocking success on 558c9f34644c444d425ae033c534cfd35a4e7568

performance benchmark with full nodes : 8065 TPS, 4919 ms latency, 7500 ms p99 latency,no expired txns
Test Ok

:white_check_mark: Forge suite compat success on testnet ==> 558c9f34644c444d425ae033c534cfd35a4e7568

Compatibility test results for testnet ==> 558c9f34644c444d425ae033c534cfd35a4e7568 (PR)
1. Check liveness of validators at old version: testnet
compatibility::simple-validator-upgrade::liveness-check : 8506 TPS, 4328 ms latency, 6200 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 558c9f34644c444d425ae033c534cfd35a4e7568
compatibility::simple-validator-upgrade::single-validator-upgrade : 5930 TPS, 6255 ms latency, 7500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 558c9f34644c444d425ae033c534cfd35a4e7568
compatibility::simple-validator-upgrade::half-validator-upgrade : 5498 TPS, 6432 ms latency, 8400 ms p99 latency,no expired txns
4. upgrading second batch to new version: 558c9f34644c444d425ae033c534cfd35a4e7568
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7335 TPS, 5065 ms latency, 10000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet ==> 558c9f34644c444d425ae033c534cfd35a4e7568 passed
Test Ok

github-actions[bot] avatar Sep 14 '22 16:09 github-actions[bot]