aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

Published 20 hours ago • verified publisher icon aptos-labs

More tests around string validation code

Open dariorussi opened this issue 2 years ago • 1 comments

Description

Adding more tests around string validation, specifically vector/string with length bigger than 1 byte (uleb128 compressed) and chopped string args. That is to make sure we cover all (or more) test cases. Also reworked the test code and grouped tests together so they run faster. Total test time goes from about 60sec to 30 sec.

Test Plan

Well this is a test....

This change is Reviewable

dariorussi avatar Sep 12 '22 22:09 dariorussi

Forge is running suite land_blocking on 4957b911b88c1ab630bd5bf3532e507b468dd371

Forge is running suite compat on testnet ==> 4957b911b88c1ab630bd5bf3532e507b468dd371

:white_check_mark: Forge suite land_blocking success on 4957b911b88c1ab630bd5bf3532e507b468dd371

performance benchmark with full nodes : 7924 TPS, 5008 ms latency, 6900 ms p99 latency,no expired txns
Test Ok

:white_check_mark: Forge suite compat success on testnet ==> 4957b911b88c1ab630bd5bf3532e507b468dd371

Compatibility test results for testnet ==> 4957b911b88c1ab630bd5bf3532e507b468dd371 (PR)
1. Check liveness of validators at old version: testnet
compatibility::simple-validator-upgrade::liveness-check : 7597 TPS, 4815 ms latency, 6900 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 4957b911b88c1ab630bd5bf3532e507b468dd371
compatibility::simple-validator-upgrade::single-validator-upgrade : 5914 TPS, 6273 ms latency, 9500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 4957b911b88c1ab630bd5bf3532e507b468dd371
compatibility::simple-validator-upgrade::half-validator-upgrade : 5686 TPS, 6191 ms latency, 9900 ms p99 latency,no expired txns
4. upgrading second batch to new version: 4957b911b88c1ab630bd5bf3532e507b468dd371
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7290 TPS, 4790 ms latency, 8900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet ==> 4957b911b88c1ab630bd5bf3532e507b468dd371 passed
Test Ok

Forge is running suite land_blocking on 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3

Forge is running suite compat on testnet ==> 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3

:white_check_mark: Forge suite land_blocking success on 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3

performance benchmark with full nodes : 7971 TPS, 4974 ms latency, 9300 ms p99 latency,no expired txns
Test Ok

:white_check_mark: Forge suite compat success on testnet ==> 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3

Compatibility test results for testnet ==> 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3 (PR)
1. Check liveness of validators at old version: testnet
compatibility::simple-validator-upgrade::liveness-check : 8605 TPS, 4327 ms latency, 6500 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3
compatibility::simple-validator-upgrade::single-validator-upgrade : 6350 TPS, 5843 ms latency, 7500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3
compatibility::simple-validator-upgrade::half-validator-upgrade : 5422 TPS, 6703 ms latency, 9300 ms p99 latency,no expired txns
4. upgrading second batch to new version: 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7788 TPS, 4647 ms latency, 8500 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet ==> 8c54e63914a71a7a1feae5aef4cc1486a2ca42d3 passed
Test Ok

github-actions[bot] avatar Sep 14 '22 15:09 github-actions[bot]