aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[cli] Add `Raw` type to support passing BCS-encoded parameters directly

Open icodezjb opened this issue 2 years ago • 1 comments

Description

After u8, u64, u128, bool, hex, string, address are passed in cmd, they are encoded again by BCS.

Test Plan

Add Raw type which is encoded by BCS, and passed in with Hex format.


This change is Reviewable

icodezjb avatar Sep 06 '22 02:09 icodezjb

Forge is running with a7e444a2fa6d77a3a4a27e37b2d36d38b72ee657

:white_check_mark: Forge test success on a7e444a2fa6d77a3a4a27e37b2d36d38b72ee657

performance benchmark with full nodes : 6983 TPS, 4272 ms latency, 6000 ms p99 latency,no expired txns
Test Ok

Forge is running suite land_blocking on bbdd39c675359215cde15646b6c14bff47f8553a

Forge is running suite compat on testnet ==> bbdd39c675359215cde15646b6c14bff47f8553a

:white_check_mark: Forge suite compat success on testnet ==> bbdd39c675359215cde15646b6c14bff47f8553a

Compatibility test results for testnet ==> bbdd39c675359215cde15646b6c14bff47f8553a (PR)
1. Check liveness of validators at old version: testnet
compatibility::simple-validator-upgrade::liveness-check : 6570 TPS, 3332 ms latency, 4100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: bbdd39c675359215cde15646b6c14bff47f8553a
compatibility::simple-validator-upgrade::single-validator-upgrade : 6347 TPS, 4019 ms latency, 5450 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: bbdd39c675359215cde15646b6c14bff47f8553a
compatibility::simple-validator-upgrade::half-validator-upgrade : 6431 TPS, 3947 ms latency, 5750 ms p99 latency,no expired txns
4. upgrading second batch to new version: bbdd39c675359215cde15646b6c14bff47f8553a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6411 TPS, 3507 ms latency, 5100 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet ==> bbdd39c675359215cde15646b6c14bff47f8553a passed
Test Ok

:white_check_mark: Forge suite land_blocking success on bbdd39c675359215cde15646b6c14bff47f8553a

performance benchmark with full nodes : 7039 TPS, 4240 ms latency, 6000 ms p99 latency,no expired txns
Test Ok

github-actions[bot] avatar Sep 12 '22 04:09 github-actions[bot]

Thanks for doing this!

gregnazario avatar Sep 14 '22 04:09 gregnazario