aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[framework] Tidying up

Open davidiw opened this issue 2 years ago • 1 comments

This PR looks to clean up a lot of old uglies from our legacy.... why... I claim OCD.

  • Starting with the script allowlist, since this is obviously not necessary for our use cases
  • Removing the validator_set_script from Diem days, while leaving a lot of the old management harness so that the team can build out new smoketests before destroying the general outline.
  • Removing some old resource parsers within types (registered_currencies)
  • Removing some DPN flags in core configuration
  • Finally eliminating transaction publishing options for so many reasons

taking a break from more to review some code!


This change is Reviewable

davidiw avatar Jul 31 '22 05:07 davidiw

:white_check_mark: Forge test success on f24575670d3ae7839519bd02eef0f81fbc4cfc8a

all up : 4962 TPS, 2232 ms latency, 2950 ms p99 latency,no expired txns

github-actions[bot] avatar Jul 31 '22 05:07 github-actions[bot]

:white_check_mark: Forge test success on bb3a91a7d1c61ea7a764c278e7df211653e1b6ee

all up : 5063 TPS, 2189 ms latency, 2950 ms p99 latency,no expired txns

github-actions[bot] avatar Jul 31 '22 16:07 github-actions[bot]