aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Feature Request] Add `nhc configuration list-evaluators` subcommand

Open banool opened this issue 3 years ago • 0 comments
trafficstars

Currently the best way to see what the evaluator choices are is to run a command like this:

$ cargo run -- configuration create --evaluators x --url http://whatever.com --configuration-name test --configuration-name-pretty test
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator system_information_build_commit_hash
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator consensus_proposals
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator consensus_round
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator consensus_timeouts
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator api_latency
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator network_minimum_peers
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator network_peers_within_tolerance
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator state_sync_version
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator performance_tps
[2022-07-26T16:25:37Z INFO  aptos_node_checker::evaluator::traits] Did not build evaluator api_transaction_availability
Error: Configuration failed validation

Caused by:
    0: Failed to build evaluators
    1: The given evaluator identifiers were unexpected: {"x"}

This is clearly a bit of a hack, it'd be good to have a bespoke subcommand for this.

banool avatar Jul 26 '22 16:07 banool