aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

Published 20 hours ago • verified publisher icon aptos-labs

[move] add const accessors to AccountAddress

Open conr2d opened this issue 7 months ago • 2 comments

Description

This PR adds const qualifier to accessors to AccountAddress inner data and a const constructor from u64.

How Has This Been Tested?

Added test case.

Key Areas to Review

This PR doesn't add non-trivial changes that can break existing code.

Type of Change

  • [x] New feature
  • [ ] Bug fix
  • [ ] Breaking change
  • [ ] Performance improvement
  • [x] Refactoring
  • [ ] Dependency update
  • [ ] Documentation update
  • [ ] Tests

Which Components or Systems Does This Change Impact?

  • [ ] Validator Node
  • [ ] Full Node (API, Indexer, etc.)
  • [ ] Move/Aptos Virtual Machine
  • [ ] Aptos Framework
  • [ ] Aptos CLI/SDK
  • [ ] Developer Infrastructure
  • [ ] Move Compiler
  • [ ] Other (specify)

Checklist

  • [x] I have read and followed the CONTRIBUTING doc
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [ ] I tested both happy and unhappy path of the functionality
  • [ ] I have made corresponding changes to the documentation

conr2d avatar Apr 11 '25 04:04 conr2d

⏱️ 7s total CI duration on this PR

Job Cumulative Duration Recent Runs
permission-check 4s 🟥 
permission-check 3s 🟥 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

trunk-io[bot] avatar Apr 11 '25 04:04 trunk-io[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar May 27 '25 02:05 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jul 12 '25 02:07 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Aug 28 '25 02:08 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Oct 28 '25 01:10 github-actions[bot]