aptos-core
aptos-core copied to clipboard
Refactor the move vm test harness to use the sdk
trafficstars
Description
In the simulation VM, it was charging the fee for keyless authentication only once if it was a single key keyless txn. It was not charging proportionate to the number of authenticators
How Has This Been Tested?
Key Areas to Review
Type of Change
- [ ] New feature
- [ ] Bug fix
- [ ] Breaking change
- [ ] Performance improvement
- [ ] Refactoring
- [ ] Dependency update
- [ ] Documentation update
- [ ] Tests
Which Components or Systems Does This Change Impact?
- [x] Validator Node
- [x] Full Node (API, Indexer, etc.)
- [ ] Move/Aptos Virtual Machine
- [ ] Aptos Framework
- [ ] Aptos CLI/SDK
- [ ] Developer Infrastructure
- [ ] Move Compiler
- [ ] Other (specify)
Checklist
- [x] I have read and followed the CONTRIBUTING doc
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I identified and added all stakeholders and component owners affected by this change as reviewers
- [ ] I tested both happy and unhappy path of the functionality
- [x] I have made corresponding changes to the documentation
⏱️ 21m total CI duration on this PR
| Job | Cumulative Duration | Recent Runs |
|---|---|---|
| check-dynamic-deps | 9m | 🟩 🟩 🟩 🟩 |
| rust-cargo-deny | 7m | 🟩 🟩 🟩 🟩 |
| semgrep/ci | 2m | 🟩 🟩 🟩 🟩 |
| general-lints | 2m | 🟩 🟩 🟩 🟩 |
| file_change_determinator | 45s | 🟩 🟩 🟩 🟩 |
| permission-check | 10s | 🟩 🟩 🟩 🟩 |
| permission-check | 10s | 🟩 🟩 🟩 🟩 |
🚨 1 job on the last run was significantly faster/slower than expected
| Job | Duration | vs 7d avg | Delta |
|---|---|---|---|
| check-dynamic-deps | 1m | 3m |
This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.