aptos-core
aptos-core copied to clipboard
simplify transaction list verify code
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
- [ ] New feature
- [ ] Bug fix
- [ ] Breaking change
- [ ] Performance improvement
- [ ] Refactoring
- [ ] Dependency update
- [ ] Documentation update
- [ ] Tests
Which Components or Systems Does This Change Impact?
- [ ] Validator Node
- [ ] Full Node (API, Indexer, etc.)
- [ ] Move/Aptos Virtual Machine
- [ ] Aptos Framework
- [ ] Aptos CLI/SDK
- [ ] Developer Infrastructure
- [ ] Move Compiler
- [ ] Other (specify)
Checklist
- [ ] I have read and followed the CONTRIBUTING doc
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I identified and added all stakeholders and component owners affected by this change as reviewers
- [ ] I tested both happy and unhappy path of the functionality
- [ ] I have made corresponding changes to the documentation
⏱️ 11h 44m total CI duration on this PR
| Slowest 15 Jobs | Cumulative Duration | Recent Runs |
|---|---|---|
| indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose | 6h | 🟥 |
| execution-performance / single-node-performance | 53m | 🟥 🟥 🟥 🟥 🟥 (+1 more) |
| rust-cargo-deny | 30m | 🟩 ⬜ 🟩 ⬜ 🟩 (+14 more) |
| check-dynamic-deps | 27m | 🟩 🟩 🟩 🟩 🟩 (+15 more) |
| execution-performance / test-target-determinator | 27m | 🟩 🟩 🟩 🟩 🟩 (+1 more) |
| test-target-determinator | 20m | 🟩 🟩 ⬜ 🟩 ⬜ (+1 more) |
| check | 17m | 🟩 🟩 ⬜ 🟩 ⬜ (+1 more) |
| rust-move-unit-coverage | 11m | 🟩 |
| rust-move-tests | 10m | 🟩 |
| rust-move-tests | 10m | 🟩 |
| rust-move-tests | 10m | 🟩 |
| rust-move-tests | 10m | 🟩 |
| rust-move-tests | 10m | 🟩 |
| rust-move-tests | 10m | 🟩 |
| rust-move-tests | 10m | 🟩 |
🚨 2 jobs on the last run were significantly faster/slower than expected
| Job | Duration | vs 7d avg | Delta |
|---|---|---|---|
| indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose | 6h | 1m | |
| execution-performance / test-target-determinator | 5m | 4m |
Forge is running suite compat on 28abb7db64af8de81a6bc76c6b2d6600181ac578 ==> ae6b08f38a0f99e9aff16d82afe08313213123b3
- Grafana dashboard (auto-refresh)
- Humio Logs
- Axiom Logs
- Validator CPU Profile
- Fullnode CPU Profile
- Test runner output
- Test run is land-blocking
Forge is running suite realistic_env_max_load on ae6b08f38a0f99e9aff16d82afe08313213123b3
- Grafana dashboard (auto-refresh)
- Humio Logs
- Axiom Logs
- Validator CPU Profile
- Fullnode CPU Profile
- Test runner output
- Test run is land-blocking
:white_check_mark: Forge suite realistic_env_max_load success on ae6b08f38a0f99e9aff16d82afe08313213123b3
two traffics test: inner traffic : committed: 13917.48 txn/s, latency: 2855.21 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 12600 ms), latency samples: 5291820
two traffics test : committed: 99.93 txn/s, latency: 1814.71 ms, (p50: 1500 ms, p70: 1600, p90: 2400 ms, p99: 9500 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.241, avg: 0.225", "QsPosToProposal: max: 1.106, avg: 1.001", "ConsensusProposalToOrdered: max: 0.309, avg: 0.294", "ConsensusOrderedToCommit: max: 0.431, avg: 0.417", "ConsensusProposalToCommit: max: 0.726, avg: 0.711"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.95s no progress at version 1254852 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.79s no progress at version 5549130 (avg 8.61s) [limit 15].
Test Ok
- Grafana dashboard
- Humio Logs
- Axiom Logs
- Validator CPU Profile
- Fullnode CPU Profile
- Test runner output
- Test run is land-blocking
Codecov Report
Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
Project coverage is 59.7%. Comparing base (
67f7ee6) to head (be1b350). Report is 317 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| types/src/transaction/mod.rs | 0.0% | 19 Missing :warning: |
| types/src/proof/accumulator/mod.rs | 0.0% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #14783 +/- ##
=======================================
Coverage 59.7% 59.7%
=======================================
Files 853 853
Lines 208283 208300 +17
=======================================
+ Hits 124530 124548 +18
+ Misses 83753 83752 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
- JS Bundle Analysis - Avoid shipping oversized bundles