[Bug][move-compiler-v2] `aptos move test --coverage --move-2` uses V1

[brmataptos]

b# 🐛 Bug

cd aptos-move/move-examples/veiled_coin
MVC_BLOCK_V1=1 aptos move test --move-2 --named-addresses veiled_coin=0x424

works ok, but

MVC_BLOCK_V1=1 aptos move test --coverage --move-2 --named-addresses veiled_coin=0x424

seems to run and pass the test, but then fails in compiler V1 code. Adding RUST_BACKTRACE=1 shows the coverage tool is requesting a build_plan which is created by V1:

   0: rust_begin_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:72:14
   2: move_compiler::naming::translate::program
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/naming/translate.rs:357:9
   3: move_compiler::command_line::compiler::run
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:810:25
   4: move_compiler::command_line::compiler::run
   5: move_compiler::command_line::compiler::SteppedCompiler<_>::run_impl
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:284:24
   6: move_compiler::command_line::compiler::SteppedCompiler<_>::run
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:341:21
   7: move_compiler::command_line::compiler::Compiler::run::{{closure}}
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:227:13
   8: core::result::Result<T,E>::and_then
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/result.rs:1321:22
   9: move_compiler::command_line::compiler::Compiler::run
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:226:66
  10: move_compiler::command_line::compiler::Compiler::build
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:251:28
  11: move_compiler::command_line::compiler::Compiler::build_and_report
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:259:34
  12: move_package::compilation::build_plan::BuildPlan::compile::{{closure}}
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/build_plan.rs:130:38
  13: move_package::compilation::compiled_package::CompiledPackage::build_all
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/compiled_package.rs:643:17
  14: move_package::compilation::build_plan::BuildPlan::compile_with_driver
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/build_plan.rs:210:33
  15: move_package::compilation::build_plan::BuildPlan::compile
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/build_plan.rs:126:9
  16: move_package::BuildConfig::compile_package
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/lib.rs:206:19
  17: aptos::move_tool::coverage::compile_coverage
             at /Users/brm/code/aptos-core/crates/aptos/src/move_tool/coverage.rs:165:19
  18: aptos::move_tool::coverage::SummaryCoverage::coverage
             at /Users/brm/code/aptos-core/crates/aptos/src/move_tool/coverage.rs:37:39
  19: <aptos::move_tool::TestPackage as aptos::common::types::CliCommand<&str>>::execute::{{closure}}
             at /Users/brm/code/aptos-core/crates/aptos/src/move_tool/mod.rs:585:13
  20: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  21: aptos::common::types::CliCommand::execute_serialized_with_logging_level::{{closure}}
             at /Users/brm/code/aptos-core/crates/aptos/src/common/types.rs:1234:28
  22: aptos::common::types::CliCommand::execute_serialized::{{closure}}

Although it crashes, the command first dumps .trace and .coverage_map.mvcov which seem able to be used to display coverage using the V1 tool:

aptos move coverage source --named-addresses veiled_coin=0x424 --module veiled_coin

is OK.

Meanwhile,

MVC_BLOCK_V1=1 aptos move coverage source --move-2 -named-addresses veiled_coin=0x424 --module veiled_coin

fails with a similar stack:

V1 compiler not expected
stack backtrace:
   0: rust_begin_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:72:14
   2: move_compiler::naming::translate::program
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/naming/translate.rs:357:9
   3: move_compiler::command_line::compiler::run
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:810:25
   4: move_compiler::command_line::compiler::run
   5: move_compiler::command_line::compiler::SteppedCompiler<_>::run_impl
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:284:24
   6: move_compiler::command_line::compiler::SteppedCompiler<_>::run
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:341:21
   7: move_compiler::command_line::compiler::Compiler::run::{{closure}}
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:227:13
   8: core::result::Result<T,E>::and_then
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/result.rs:1321:22
   9: move_compiler::command_line::compiler::Compiler::run
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:226:66
  10: move_compiler::command_line::compiler::Compiler::build
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:251:28
  11: move_compiler::command_line::compiler::Compiler::build_and_report
             at /Users/brm/code/aptos-core/third_party/move/move-compiler/src/command_line/compiler.rs:259:34
  12: move_package::compilation::build_plan::BuildPlan::compile::{{closure}}
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/build_plan.rs:130:38
  13: move_package::compilation::compiled_package::CompiledPackage::build_all
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/compiled_package.rs:643:17
  14: move_package::compilation::build_plan::BuildPlan::compile_with_driver
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/build_plan.rs:210:33
  15: move_package::compilation::build_plan::BuildPlan::compile
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/compilation/build_plan.rs:126:9
  16: move_package::BuildConfig::compile_package
             at /Users/brm/code/aptos-core/third_party/move/tools/move-package/src/lib.rs:206:19
  17: aptos::move_tool::coverage::compile_coverage
             at /Users/brm/code/aptos-core/crates/aptos/src/move_tool/coverage.rs:165:19
  18: <aptos::move_tool::coverage::SourceCoverage as aptos::common::types::CliCommand<()>>::execute::{{closure}}
             at /Users/brm/code/aptos-core/crates/aptos/src/move_tool/coverage.rs:103:39
  19: aptos::common::types::CliCommand::execute_serialized_success::{{closure}}