aptos-core [compiler-v2][linter] Support attributes to suppress specific lint warnings

Description

In this PR, we add support for suppressing specific lint warnings via attributes on functions and modules.

For example, when lint checks are enabled, running compiler v2 on the following code will report a warning:

module 0xc0ffee::m {
    public fun test(x: u8) {
        if (x < 0) abort 1;
    }
}

But, you can now add one or more lint checks to skip using the #[lint::skip(...)] attribute. For the code below, we will not report a warning when lint checks are enabled in compiler v2.

module 0xc0ffee::m {
    #[lint::skip(unnecessary_numerical_extreme_comparison)]
    public fun test(x: u8) {
        if (x < 0) abort 1;
    }
}

Multiple lint checks can also be suppressed: #[lint::skip(blocks_in_conditions, while_true)].

Important notes for the reviewer

Lint checks are not yet directly exposed to the user, and can only be exercised when compiling with v2 and MVC_EXP=lint-checks=on env flag.
Many error checks on the attribute #[lint::skip(...)] are performed only when lint checks are enabled. General checks on attributes (such as, unknown top-level attribute name such as #[lint::skippps], misplaced attribute) done regardless of whether lint checks are on, but once we have a syntactically well-formed #[lint::skip(...)] attribute, further checks are only performed when lint checks are enabled (i.e., because this is tool specific, it is offloaded to the tool).
Based on the above point, we do not perform further extensive checks on #[lint::skip(...)] attribute when using compiler v1, which does not have a linter. To allow a user to use compiler v1 and v2 on the same code base, we probably do not want to throw an error/warning on seeing #[lint::skip(...)] attributes when using compiler v1, but this can be discussed (and whatever we want to do could be done in a followup PR).

Type of Change

[x] New feature

Which Components or Systems Does This Change Impact?

[x] Move/Aptos Virtual Machine

How Has This Been Tested?

Several new tests were added to check the newly added functionality
All baseline updates of existing tests were checked for sanity

Aug 21 '24 14:08 vineethk

⏱️ 5h 25m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	45m	🟩 🟩
forge-e2e-test / forge	37m	🟩 🟩
forge-framework-upgrade-test / forge	31m	🟩 🟩
forge-compat-test / forge	28m	🟩 🟩
rust-move-unit-coverage	15m	🟩
rust-move-unit-coverage	13m	🟩
rust-move-unit-coverage	13m	🟩
test-target-determinator	13m	🟩 🟩
execution-performance / test-target-determinator	12m	🟩 🟩
general-lints	10m	🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-cargo-deny	10m	🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-tests	9m	🟩
rust-move-unit-coverage	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	8m	🟩
rust-move-tests	8m	🟩
check-dynamic-deps	8m	🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-tests	8m	🟩
rust-move-tests	8m	🟩
rust-move-unit-coverage	8m	🟩
check	7m	🟩 🟩
rust-doc-tests	5m	🟩
rust-doc-tests	4m	🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	24s	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	23s	🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator	22s	🟩 🟩
permission-check	20s	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	18s	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	6s	🟩 🟩
determine-docker-build-metadata	5s	🟩 🟩
permission-check	4s	🟩
Backport PR	3s	🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
forge-e2e-test / forge	22m	14m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

Aug 21 '24 14:08 trunk-io[bot]

#14362 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vineethk and the rest of your teammates on Graphite

Aug 21 '24 14:08 vineethk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.6%. Comparing base (25c9f79) to head (ed908e4). Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #14362    +/-   ##
========================================
  Coverage    59.6%    59.6%            
========================================
  Files         839      840     +1     
  Lines      205183   205286   +103     
========================================
+ Hits       122293   122390    +97     
- Misses      82890    82896     +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Aug 21 '24 15:08 codecov[bot]

Forge is running suite `compat` on `d1bf834728a0cf166d993f4728dfca54f3086fb0` ==> `d392cf016fb9211e6997bcb455523abafec6ccb2`

Aug 24 '24 00:08 github-actions[bot]

Forge is running suite `realistic_env_max_load` on `d392cf016fb9211e6997bcb455523abafec6ccb2`

Aug 24 '24 00:08 github-actions[bot]