aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Rosetta] Fungible Asset support

Open gregnazario opened this issue 6 months ago • 21 comments

Description

Adding fungible asset support for Rosetta, and actual unit testing over the original massive integration testing.

This supports:

  1. FA as a primary transfer
  2. FA as a secondary transfer
  3. Coin + FA as coin transfer
  4. Other coins as coin transfer
  5. Watching balance changes from both FA and Coin events
  6. Account balances for any associated coins or FA using the view functions

Type of Change

  • [x] New feature
  • [ ] Bug fix
  • [ ] Breaking change
  • [ ] Performance improvement
  • [ ] Refactoring
  • [ ] Dependency update
  • [ ] Documentation update
  • [ ] Tests

Which Components or Systems Does This Change Impact?

  • [ ] Validator Node
  • [ ] Full Node (API, Indexer, etc.)
  • [ ] Move/Aptos Virtual Machine
  • [ ] Aptos Framework
  • [ ] Aptos CLI/SDK
  • [ ] Developer Infrastructure
  • [x] Other (specify) Rosetta

How Has This Been Tested?

  • The existing E2E test for Rosetta
  • New unit tests to check parsing for Rosetta

Key Areas to Review

  • Ensure that the naming is correct for the parsing, will have to test it out on Devnet / Testnet with real time changes.

Checklist

  • [x] I have read and followed the CONTRIBUTING doc
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [x] I tested both happy and unhappy path of the functionality
  • [x] I have made corresponding changes to the documentation

gregnazario avatar Aug 02 '24 05:08 gregnazario