aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

slice node

Open msmouse opened this issue 9 months ago • 1 comments

Description

Type of Change

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Breaking change
  • [ ] Performance improvement
  • [ ] Refactoring
  • [ ] Dependency update
  • [ ] Documentation update
  • [ ] Tests

Which Components or Systems Does This Change Impact?

  • [ ] Validator Node
  • [ ] Full Node (API, Indexer, etc.)
  • [ ] Move/Aptos Virtual Machine
  • [ ] Aptos Framework
  • [ ] Aptos CLI/SDK
  • [ ] Developer Infrastructure
  • [ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • [ ] I have read and followed the CONTRIBUTING doc
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [ ] I tested both happy and unhappy path of the functionality
  • [ ] I have made corresponding changes to the documentation

msmouse avatar May 10 '24 23:05 msmouse

⏱️ 22h 18m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 3h 29m 🟩🟩🟩🟩 (+9 more)
execution-performance / single-node-performance 3h 28m 🟥🟥🟩🟩🟩 (+3 more)
rust-smoke-tests 2h 15m 🟩🟩🟩🟩
rust-move-tests 1h 55m 🟩🟩🟩🟩 (+9 more)
windows-build 1h 20m 🟩🟩
forge-framework-upgrade-test / forge 1h 16m 🟩
run-tests-main-branch 1h 6m 🟩🟩🟩🟩🟩 (+10 more)
rust-images / rust-all 1h 4m 🟩🟩🟩 (+1 more)
forge-e2e-test / forge 55m 🟩🟩🟩🟩
forge-compat-test / forge 53m 🟩🟩🟩🟩
rust-lints 53m 🟩🟥🟩🟩🟩 (+9 more)
single-node-performance 35m 🟥
cli-e2e-tests / run-cli-tests 33m 🟥🟩🟥🟥
execution-performance / test-target-determinator 25m 🟩🟩🟩🟩🟩 (+2 more)
rust-build-cached-packages 21m 🟩🟩🟩🟩🟩
test-target-determinator 20m 🟩🟩🟩🟩🟩 (+1 more)
check-dynamic-deps 20m 🟩🟩🟩🟩🟩 (+10 more)
general-lints 20m 🟩🟩🟩🟩🟩 (+9 more)
check 20m 🟩🟩🟩🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 7m 🟩🟩🟩🟥
semgrep/ci 6m 🟩🟩🟩🟩🟩 (+10 more)
test-target-determinator 4m 🟩
node-api-compatibility-tests / node-api-compatibility-tests 3m 🟩🟩🟩🟩
file_change_determinator 3m 🟩🟩🟩🟩🟩 (+10 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+9 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+1 more)
permission-check 50s 🟩🟩🟩🟩🟩 (+11 more)
permission-check 48s 🟩🟩🟩🟩🟩 (+10 more)
permission-check 43s 🟩🟩🟩🟩 (+10 more)
permission-check 42s 🟩🟩🟩🟩 (+11 more)
permission-check 19s 🟩🟩🟩🟩🟩
determine-docker-build-metadata 11s 🟩🟩🟩🟩🟩 (+1 more)

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 9m 7m +30%
rust-targeted-unit-tests 23m 18m +28%
rust-lints 5m 7m -21%

settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar May 10 '24 23:05 trunk-io[bot]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> ae1737ea3b60c2524f1260c60d28535ee2b70e15

github-actions[bot] avatar May 13 '24 20:05 github-actions[bot]

Forge is running suite realistic_env_max_load on ae1737ea3b60c2524f1260c60d28535ee2b70e15

github-actions[bot] avatar May 13 '24 20:05 github-actions[bot]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> ae1737ea3b60c2524f1260c60d28535ee2b70e15

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> ae1737ea3b60c2524f1260c60d28535ee2b70e15 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5276 txn/s, latency: 5410 ms, (p50: 4800 ms, p90: 8500 ms, p99: 11700 ms), latency samples: 232180
2. Upgrading first Validator to new version: ae1737ea3b60c2524f1260c60d28535ee2b70e15
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1510 txn/s, latency: 17380 ms, (p50: 18700 ms, p90: 30700 ms, p99: 31200 ms), latency samples: 92120
3. Upgrading rest of first batch to new version: ae1737ea3b60c2524f1260c60d28535ee2b70e15
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1701 txn/s, latency: 16392 ms, (p50: 19300 ms, p90: 24100 ms, p99: 25000 ms), latency samples: 91880
4. upgrading second batch to new version: ae1737ea3b60c2524f1260c60d28535ee2b70e15
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3438 txn/s, latency: 9099 ms, (p50: 9900 ms, p90: 12200 ms, p99: 13000 ms), latency samples: 137520
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> ae1737ea3b60c2524f1260c60d28535ee2b70e15 passed
Test Ok

github-actions[bot] avatar May 13 '24 20:05 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on ae1737ea3b60c2524f1260c60d28535ee2b70e15

two traffics test: inner traffic : committed: 7865 txn/s, latency: 4983 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10200 ms), latency samples: 3398060
two traffics test : committed: 100 txn/s, latency: 1802 ms, (p50: 1800 ms, p90: 2000 ms, p99: 2200 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.214, avg: 0.202", "QsPosToProposal: max: 0.250, avg: 0.238", "ConsensusProposalToOrdered: max: 0.460, avg: 0.414", "ConsensusOrderedToCommit: max: 0.367, avg: 0.356", "ConsensusProposalToCommit: max: 0.778, avg: 0.770"]
Max round gap was 1 [limit 4] at version 1656808. Max no progress secs was 4.86933 [limit 15] at version 1656808.
Test Ok

github-actions[bot] avatar May 13 '24 21:05 github-actions[bot]

Forge is running suite realistic_env_max_load on 0b70678a2b43906108850fd58c8707fda5b910ca

github-actions[bot] avatar May 13 '24 22:05 github-actions[bot]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b70678a2b43906108850fd58c8707fda5b910ca

github-actions[bot] avatar May 13 '24 22:05 github-actions[bot]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b70678a2b43906108850fd58c8707fda5b910ca

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b70678a2b43906108850fd58c8707fda5b910ca (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6626.8670395278305 txn/s, latency: 4973.796083819993 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9900 ms), latency samples: 232880
2. Upgrading first Validator to new version: 0b70678a2b43906108850fd58c8707fda5b910ca
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1821.907704276195 txn/s, latency: 15697.521211790394 ms, (p50: 18400 ms, p90: 22200 ms, p99: 22800 ms), latency samples: 91600
3. Upgrading rest of first batch to new version: 0b70678a2b43906108850fd58c8707fda5b910ca
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1576.1386972112402 txn/s, latency: 16705.284734320558 ms, (p50: 19300 ms, p90: 26800 ms, p99: 28600 ms), latency samples: 91840
4. upgrading second batch to new version: 0b70678a2b43906108850fd58c8707fda5b910ca
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3581.431188453236 txn/s, latency: 8765.229129711752 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12800 ms), latency samples: 144320
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 0b70678a2b43906108850fd58c8707fda5b910ca passed
Test Ok

github-actions[bot] avatar May 13 '24 22:05 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on 0b70678a2b43906108850fd58c8707fda5b910ca

two traffics test: inner traffic : committed: 8139.58434612306 txn/s, latency: 4800.049334001314 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10500 ms), latency samples: 3533040
two traffics test : committed: 99.97055984467882 txn/s, latency: 1896.0258426966293 ms, (p50: 1800 ms, p90: 2200 ms, p99: 3200 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.203", "QsPosToProposal: max: 0.242, avg: 0.222", "ConsensusProposalToOrdered: max: 0.437, avg: 0.417", "ConsensusOrderedToCommit: max: 0.387, avg: 0.369", "ConsensusProposalToCommit: max: 0.801, avg: 0.786"]
Max round gap was 1 [limit 4] at version 1745359. Max no progress secs was 4.795982 [limit 15] at version 1745359.
Test Ok

github-actions[bot] avatar May 13 '24 22:05 github-actions[bot]

Forge is running suite realistic_env_max_load on 82fbf8d5eee7434b87b4582caed35f69ffdec534

github-actions[bot] avatar May 13 '24 23:05 github-actions[bot]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 82fbf8d5eee7434b87b4582caed35f69ffdec534

github-actions[bot] avatar May 13 '24 23:05 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on 82fbf8d5eee7434b87b4582caed35f69ffdec534

two traffics test: inner traffic : committed: 8041.463912398282 txn/s, latency: 4875.29511079552 ms, (p50: 4500 ms, p90: 5700 ms, p99: 12900 ms), latency samples: 3478480
two traffics test : committed: 99.99053240183957 txn/s, latency: 1957.702808988764 ms, (p50: 1800 ms, p90: 2100 ms, p99: 9300 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.202", "QsPosToProposal: max: 0.334, avg: 0.249", "ConsensusProposalToOrdered: max: 0.451, avg: 0.414", "ConsensusOrderedToCommit: max: 0.400, avg: 0.363", "ConsensusProposalToCommit: max: 0.840, avg: 0.776"]
Max round gap was 1 [limit 4] at version 1826776. Max no progress secs was 4.822419 [limit 15] at version 1826776.
Test Ok

github-actions[bot] avatar May 13 '24 23:05 github-actions[bot]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 82fbf8d5eee7434b87b4582caed35f69ffdec534

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 82fbf8d5eee7434b87b4582caed35f69ffdec534 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5702.631009538081 txn/s, latency: 5756.1657691546225 ms, (p50: 5100 ms, p90: 8900 ms, p99: 9700 ms), latency samples: 202040
2. Upgrading first Validator to new version: 82fbf8d5eee7434b87b4582caed35f69ffdec534
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1461.2279164515082 txn/s, latency: 19628.744431971263 ms, (p50: 19200 ms, p90: 30700 ms, p99: 31100 ms), latency samples: 89080
3. Upgrading rest of first batch to new version: 82fbf8d5eee7434b87b4582caed35f69ffdec534
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1353.5653957471184 txn/s, latency: 18864.161729518855 ms, (p50: 21800 ms, p90: 29300 ms, p99: 30000 ms), latency samples: 76900
4. upgrading second batch to new version: 82fbf8d5eee7434b87b4582caed35f69ffdec534
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2953.723204457026 txn/s, latency: 10213.481481189989 ms, (p50: 9900 ms, p90: 12300 ms, p99: 12900 ms), latency samples: 127060
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 82fbf8d5eee7434b87b4582caed35f69ffdec534 passed
Test Ok

github-actions[bot] avatar May 13 '24 23:05 github-actions[bot]

  • #13249 Graphite 👈
  • #13283 Graphite: 1 other dependent PR (#13284 Graphite)
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @msmouse and the rest of your teammates on Graphite Graphite

msmouse avatar May 15 '24 04:05 msmouse

Forge is running suite realistic_env_max_load on 28076aaf382f3045543d7aa6ca13d930745682a2

github-actions[bot] avatar May 15 '24 04:05 github-actions[bot]

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2

github-actions[bot] avatar May 15 '24 04:05 github-actions[bot]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2

github-actions[bot] avatar May 15 '24 04:05 github-actions[bot]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5290.314710740663 txn/s, latency: 5447.658429610612 ms, (p50: 4800 ms, p90: 9000 ms, p99: 11900 ms), latency samples: 233700
2. Upgrading first Validator to new version: 28076aaf382f3045543d7aa6ca13d930745682a2
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1693.9030370348698 txn/s, latency: 16665.066922036953 ms, (p50: 19300 ms, p90: 22300 ms, p99: 22800 ms), latency samples: 88760
3. Upgrading rest of first batch to new version: 28076aaf382f3045543d7aa6ca13d930745682a2
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1679.4870989772169 txn/s, latency: 15783.421120969488 ms, (p50: 19100 ms, p90: 22000 ms, p99: 25000 ms), latency samples: 92420
4. upgrading second batch to new version: 28076aaf382f3045543d7aa6ca13d930745682a2
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3534.672441574259 txn/s, latency: 8878.859875346261 ms, (p50: 9600 ms, p90: 12700 ms, p99: 13000 ms), latency samples: 144400
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 passed
Test Ok

github-actions[bot] avatar May 15 '24 05:05 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on 28076aaf382f3045543d7aa6ca13d930745682a2

two traffics test: inner traffic : committed: 8080.8678873411145 txn/s, latency: 4849.750587975977 ms, (p50: 4500 ms, p90: 5700 ms, p99: 13200 ms), latency samples: 3493340
two traffics test : committed: 100.05156256990895 txn/s, latency: 1863.8155172413792 ms, (p50: 1800 ms, p90: 2100 ms, p99: 3600 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.202", "QsPosToProposal: max: 0.344, avg: 0.239", "ConsensusProposalToOrdered: max: 0.480, avg: 0.440", "ConsensusOrderedToCommit: max: 0.377, avg: 0.367", "ConsensusProposalToCommit: max: 0.847, avg: 0.807"]
Max round gap was 1 [limit 4] at version 1731548. Max no progress secs was 6.414748 [limit 15] at version 1731548.
Test Ok

github-actions[bot] avatar May 15 '24 05:05 github-actions[bot]

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 (PR)
Upgrade the nodes to version: 28076aaf382f3045543d7aa6ca13d930745682a2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1150.2883897885888 txn/s, submitted: 1153.8013911698863 txn/s, failed submission: 3.5130013812974656 txn/s, expired: 3.5130013812974656 txn/s, latency: 2545.4613953044473 ms, (p50: 2100 ms, p90: 4500 ms, p99: 7500 ms), latency samples: 104780
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1268.593516786563 txn/s, submitted: 1270.2668076509883 txn/s, failed submission: 1.6732908644254645 txn/s, expired: 1.6732908644254645 txn/s, latency: 2533.740653853401 ms, (p50: 2400 ms, p90: 4000 ms, p99: 5700 ms), latency samples: 106140
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 28076aaf382f3045543d7aa6ca13d930745682a2 passed
Upgrade the remaining nodes to version: 28076aaf382f3045543d7aa6ca13d930745682a2
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1170.8030185685209 txn/s, submitted: 1173.6769685763363 txn/s, failed submission: 2.873950007815478 txn/s, expired: 2.873950007815478 txn/s, latency: 2663.390237915408 ms, (p50: 2100 ms, p90: 4500 ms, p99: 6100 ms), latency samples: 105920
Test Ok

github-actions[bot] avatar May 15 '24 06:05 github-actions[bot]