Disallow creation of CoinStore<NOT_COIN_TYPE> and also migration of it

[lightmark]

Description

We ever allow creation of CoinStore<0x1::string::String>. We have to fix this.

Type of Change

• [ ] New feature
• [x] Bug fix
• [ ] Breaking change
• [ ] Performance improvement
• [ ] Refactoring
• [ ] Dependency update
• [ ] Documentation update
• [ ] Tests

Which Components or Systems Does This Change Impact?

• [ ] Validator Node
• [ ] Full Node (API, Indexer, etc.)
• [ ] Move/Aptos Virtual Machine
• [x] Aptos Framework
• [ ] Aptos CLI/SDK
• [ ] Developer Infrastructure
• [ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• [x] I have read and followed the CONTRIBUTING doc
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I identified and added all stakeholders and component owners affected by this change as reviewers
• [x] I tested both happy and unhappy path of the functionality
• [x] I have made corresponding changes to the documentation

[trunk-io[bot]]

⏱️ 1h 15m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-move-unit-coverage	24m	🟩
rust-targeted-unit-tests	21m	🟥
rust-move-tests	16m	🟩
rust-lints	6m	🟩
run-tests-main-branch	4m	🟩
general-lints	2m	🟩
check-dynamic-deps	1m	🟩
semgrep/ci	29s	🟩
file_change_determinator	12s	🟩
file_change_determinator	11s	🟩
permission-check	4s	🟩
permission-check	3s	🟩
permission-check	2s	🟩
permission-check	2s	🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-move-tests	16m	9m
rust-move-unit-coverage	24m	20m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.6%. Comparing base (7719765) to head (7722efa). Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13228   +/-   ##
=======================================
  Coverage    57.6%    57.6%           
=======================================
  Files         834      834           
  Lines      198396   198396           
=======================================
  Hits       114325   114325           
  Misses      84071    84071           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite realistic_env_max_load on 7722efaa2700a02a7c72c49003f3ae686118543c

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5997.17329345885 txn/s, latency: 5243.108934274668 ms, (p50: 4800 ms, p90: 9900 ms, p99: 12700 ms), latency samples: 237960
2. Upgrading first Validator to new version: 7722efaa2700a02a7c72c49003f3ae686118543c
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1840.5824630561635 txn/s, latency: 15600.282810799043 ms, (p50: 19400 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 91860
3. Upgrading rest of first batch to new version: 7722efaa2700a02a7c72c49003f3ae686118543c
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1817.777840536495 txn/s, latency: 15739.217242510387 ms, (p50: 19200 ms, p90: 21600 ms, p99: 22700 ms), latency samples: 91460
4. upgrading second batch to new version: 7722efaa2700a02a7c72c49003f3ae686118543c
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3526.6820832115827 txn/s, latency: 8892.496347222223 ms, (p50: 9600 ms, p90: 12700 ms, p99: 13000 ms), latency samples: 144000
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite realistic_env_max_load success on 7722efaa2700a02a7c72c49003f3ae686118543c

two traffics test: inner traffic : committed: 7016.119596141195 txn/s, latency: 5587.441780907771 ms, (p50: 5400 ms, p90: 6600 ms, p99: 11700 ms), latency samples: 3031600
two traffics test : committed: 100.08366253131607 txn/s, latency: 1908.0283333333334 ms, (p50: 1800 ms, p90: 2200 ms, p99: 2600 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.201", "QsPosToProposal: max: 0.343, avg: 0.290", "ConsensusProposalToOrdered: max: 0.475, avg: 0.450", "ConsensusOrderedToCommit: max: 0.385, avg: 0.364", "ConsensusProposalToCommit: max: 0.839, avg: 0.814"]
Max round gap was 1 [limit 4] at version 1437791. Max no progress secs was 4.199455 [limit 15] at version 1437791.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c (PR)
Upgrade the nodes to version: 7722efaa2700a02a7c72c49003f3ae686118543c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1203.2444711918258 txn/s, submitted: 1205.6752681033242 txn/s, failed submission: 2.430796911498638 txn/s, expired: 2.430796911498638 txn/s, latency: 2510.635730027548 ms, (p50: 2100 ms, p90: 3900 ms, p99: 6000 ms), latency samples: 108900
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1202.348300304795 txn/s, submitted: 1205.0741985862342 txn/s, failed submission: 2.725898281439173 txn/s, expired: 2.725898281439173 txn/s, latency: 2704.507953901379 ms, (p50: 2100 ms, p90: 4800 ms, p99: 6600 ms), latency samples: 105860
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7722efaa2700a02a7c72c49003f3ae686118543c passed
Upgrade the remaining nodes to version: 7722efaa2700a02a7c72c49003f3ae686118543c
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1195.9674048301965 txn/s, submitted: 1198.5174419407087 txn/s, failed submission: 2.550037110512146 txn/s, expired: 2.550037110512146 txn/s, latency: 2780.147421981004 ms, (p50: 2400 ms, p90: 4800 ms, p99: 6500 ms), latency samples: 103180
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking