aptos-core [storage] turn on feature flag for remove_detailed_error_from

Description

for v1.12 testnet release

Type of Change

[x] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[x] Validator Node
[x] Full Node (API, Indexer, etc.)
[ ] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

How Has This Been Tested?

The internal error info was tested previously through unit tests

with devnet

Before the feature is on

transaction https://explorer.aptoslabs.com/txn/1319701?network=devnet Move abort in 0x1::from_bcs: EINVALID_UTF8(0x10001): UTF8 check failed in conversion from bytes to string [with detail error]

Run governance proposal to enable the feature https://explorer.aptoslabs.com/txn/1325739?network=devnet

We still have the error details as expected. Devnet is also running healthy https://explorer.aptoslabs.com/txn/1327821?network=devnet

Key Areas to Review

Checklist

[ ] I have read and followed the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I identified and added all stakeholders and component owners affected by this change as reviewers
[ ] I tested both happy and unhappy path of the functionality
[ ] I have made corresponding changes to the documentation

May 03 '24 22:05 areshand

⏱️ 15h total CI duration on this PR

Job	Cumulative Duration	Recent Runs
forge-framework-upgrade-test / forge	3h 26m	⬜ 🟩 🟩
rust-targeted-unit-tests	1h 59m	🟥 ⬜ ⬜ 🟥 🟥 (+2 more)
rust-move-tests	1h 25m	🟥 ⬜ ⬜ 🟥 🟥 (+2 more)
rust-smoke-tests	1h 11m	🟩 🟩
rust-lints	55m	🟩 ⬜ 🟩 🟩 🟩 (+2 more)
rust-move-unit-coverage	53m	⬜ 🟩 🟩
windows-build	53m	🟩 🟥
execution-performance / single-node-performance	46m	🟥 🟥
run-tests-main-branch	42m	🟩 🟩 🟩 🟩 🟩 (+5 more)
forge-compat-test / forge	33m	🟩 🟩
rust-images / rust-all	31m	🟩 🟩
forge-e2e-test / forge	27m	🟩 🟩
cli-e2e-tests / run-cli-tests	13m	🟩 🟩
general-lints	13m	🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-build-cached-packages	12m	🟩 🟩
check-dynamic-deps	9m	🟩 🟩 🟩 🟩 🟩 (+2 more)
check	8m	🟩 🟩
execution-performance / test-target-determinator	7m	🟩 🟩
test-target-determinator	7m	🟩 🟩
semgrep/ci	3m	🟩 🟩 🟩 🟩 🟩 (+2 more)
node-api-compatibility-tests / node-api-compatibility-tests	2m	🟩 🟩
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+4 more)
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+2 more)
permission-check	30s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	24s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	24s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	24s	🟩 🟩 🟩 🟩 🟩 (+4 more)
file_change_determinator	20s	🟩 🟩
permission-check	5s	🟩 🟩
determine-docker-build-metadata	4s	🟩 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-images / rust-all	19m	14m
rust-lints	5m	9m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

May 03 '24 22:05 trunk-io[bot]

enable here for devnet genesis as well, please:

https://github.com/aptos-labs/aptos-core/blob/bbf569abd260d94bc30fe96da297d2aecb193644/types/src/on_chain_config/aptos_features.rs#L134-L137

May 03 '24 22:05 msmouse

Codecov Report

Attention: Patch coverage is 6.06061% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 57.6%. Comparing base (6cdd4c2) to head (bf5010f). Report is 5 commits behind head on main.

Files	Patch %	Lines
types/src/transaction/mod.rs	0.0%	23 Missing :warning:
types/src/proof/definition.rs	0.0%	8 Missing :warning:

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #13197     +/-   ##
=========================================
- Coverage    57.6%    57.6%   -0.1%     
=========================================
  Files         834      834             
  Lines      198397   198430     +33     
=========================================
+ Hits       114318   114320      +2     
- Misses      84079    84110     +31

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

May 10 '24 17:05 codecov[bot]

Forge is running suite `framework_upgrade` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `3f70dece805a5d0db26c8f5073a13d39a2c90d6d`

May 10 '24 17:05 github-actions[bot]

Forge is running suite `realistic_env_max_load` on `3f70dece805a5d0db26c8f5073a13d39a2c90d6d`

May 10 '24 17:05 github-actions[bot]

Forge is running suite `compat` on `01b24e7e3548382dd25440b39a0438a993387f12` ==> `3f70dece805a5d0db26c8f5073a13d39a2c90d6d`

May 10 '24 17:05 github-actions[bot]

:white_check_mark: Forge suite `realistic_env_max_load` success on `3f70dece805a5d0db26c8f5073a13d39a2c90d6d`

two traffics test: inner traffic : committed: 8151 txn/s, latency: 4808 ms, (p50: 4500 ms, p90: 5600 ms, p99: 10800 ms), latency samples: 3521660
two traffics test : committed: 100 txn/s, latency: 1841 ms, (p50: 1800 ms, p90: 2200 ms, p99: 2300 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.201, avg: 0.201", "QsPosToProposal: max: 0.233, avg: 0.220", "ConsensusProposalToOrdered: max: 0.472, avg: 0.413", "ConsensusOrderedToCommit: max: 0.380, avg: 0.361", "ConsensusProposalToCommit: max: 0.787, avg: 0.774"]
Max round gap was 1 [limit 4] at version 1753121. Max no progress secs was 4.761114 [limit 15] at version 1753121.
Test Ok

May 10 '24 18:05 github-actions[bot]