aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard
verified publisher icon aptos-labs

recalibrate for FA (pairs and dispatchable) regressions and state key improvement

Open igor-aptos opened this issue 1 year ago • 1 comments

Description

Type of Change

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Breaking change
  • [ ] Performance improvement
  • [ ] Refactoring
  • [ ] Dependency update
  • [ ] Documentation update
  • [ ] Tests

Which Components or Systems Does This Change Impact?

  • [ ] Validator Node
  • [ ] Full Node (API, Indexer, etc.)
  • [ ] Move/Aptos Virtual Machine
  • [ ] Aptos Framework
  • [ ] Aptos CLI/SDK
  • [ ] Developer Infrastructure
  • [ ] Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • [ ] I have read and followed the CONTRIBUTING doc
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [ ] I tested both happy and unhappy path of the functionality
  • [ ] I have made corresponding changes to the documentation

igor-aptos avatar May 02 '24 01:05 igor-aptos

⏱️ 10h 7m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 2h 57m 🟩 🟩 🟩 🟩 🟩 
rust-targeted-unit-tests 1h 14m 🟩 🟩 🟩 
forge-framework-upgrade-test / forge 1h 13m 🟩 
rust-move-tests 38m 🟩 🟩 🟩 
rust-images / rust-all 37m 🟩 🟩 🟩 
windows-build 36m 🟩 
rust-smoke-tests 32m 🟩 
rust-unit-tests 27m 🟩 
rust-lints 21m 🟩 🟩 🟩 
forge-e2e-test / forge 18m 🟩 
forge-compat-test / forge 16m 🟩 
run-tests-main-branch 14m 🟩 🟩 🟩 
cli-e2e-tests / run-cli-tests 10m 🟥 
framework-upgrade-determinator 9m 🟩 🟩 🟩 
check-dynamic-deps 6m 🟩 🟩 🟩 🟩 🟩 
general-lints 6m 🟩 🟩 🟩 
check 4m 🟩 
rust-build-cached-packages 4m 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 1m 🟩 🟩 🟩 
execution-performance / file_change_determinator 55s 🟩 🟩 🟩 🟩 🟩 
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩 
file_change_determinator 32s 🟩 🟩 🟩 
file_change_determinator 30s 🟩 🟩 🟩 
permission-check 15s 🟩 🟩 🟩 🟩 🟩 
permission-check 13s 🟩 🟩 🟩 🟩 🟩 
permission-check 8s 🟩 🟩 🟩 
determine-docker-build-metadata 8s 🟩 🟩 🟩 
permission-check 7s 🟩 🟩 🟩 
permission-check 7s 🟩 🟩 🟩 
🚨 7 jobs on the last run were significantly faster/slower than expected
Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 10m 7m +44%
execution-performance / single-node-performance 35m 25m +43%
rust-targeted-unit-tests 23m 16m +43%
rust-move-tests 11m 9m +26%
forge-e2e-test / forge 18m 15m +20%
rust-build-cached-packages 4m 5m -23%
framework-upgrade-determinator 3m 4m -36%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

trunk-io[bot] avatar May 02 '24 01:05 trunk-io[bot]

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd

github-actions[bot] avatar May 02 '24 18:05 github-actions[bot]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd

github-actions[bot] avatar May 02 '24 18:05 github-actions[bot]

Forge is running suite realistic_env_max_load on 7b2b162bd24b916fa87994e08065c466f2ab17cd

github-actions[bot] avatar May 02 '24 18:05 github-actions[bot]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 5423 txn/s, latency: 6086 ms, (p50: 5400 ms, p90: 9400 ms, p99: 13300 ms), latency samples: 189820
2. Upgrading first Validator to new version: 7b2b162bd24b916fa87994e08065c466f2ab17cd
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1253 txn/s, latency: 20431 ms, (p50: 24700 ms, p90: 30100 ms, p99: 32000 ms), latency samples: 75180
3. Upgrading rest of first batch to new version: 7b2b162bd24b916fa87994e08065c466f2ab17cd
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1789 txn/s, latency: 16353 ms, (p50: 18400 ms, p90: 23200 ms, p99: 23500 ms), latency samples: 91280
4. upgrading second batch to new version: 7b2b162bd24b916fa87994e08065c466f2ab17cd
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3615 txn/s, latency: 8807 ms, (p50: 9500 ms, p90: 12600 ms, p99: 12900 ms), latency samples: 144600
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd passed
Test Ok

github-actions[bot] avatar May 02 '24 18:05 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on 7b2b162bd24b916fa87994e08065c466f2ab17cd

two traffics test: inner traffic : committed: 7850 txn/s, latency: 4998 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10400 ms), latency samples: 3391620
two traffics test : committed: 100 txn/s, latency: 2011 ms, (p50: 1900 ms, p90: 2200 ms, p99: 6700 ms), latency samples: 1720
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.207", "QsPosToProposal: max: 0.244, avg: 0.228", "ConsensusProposalToOrdered: max: 0.431, avg: 0.417", "ConsensusOrderedToCommit: max: 0.384, avg: 0.368", "ConsensusProposalToCommit: max: 0.803, avg: 0.785"]
Max round gap was 1 [limit 4] at version 1335366. Max no progress secs was 4.611509 [limit 15] at version 1335366.
Test Ok

github-actions[bot] avatar May 02 '24 18:05 github-actions[bot]

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd (PR)
Upgrade the nodes to version: 7b2b162bd24b916fa87994e08065c466f2ab17cd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1291 txn/s, submitted: 1294 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2390 ms, (p50: 1900 ms, p90: 4200 ms, p99: 6300 ms), latency samples: 113660
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1218 txn/s, submitted: 1220 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2650 ms, (p50: 2100 ms, p90: 4500 ms, p99: 6900 ms), latency samples: 103600
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 7b2b162bd24b916fa87994e08065c466f2ab17cd passed
Upgrade the remaining nodes to version: 7b2b162bd24b916fa87994e08065c466f2ab17cd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1211 txn/s, submitted: 1214 txn/s, failed submission: 3 txn/s, expired: 3 txn/s, latency: 2616 ms, (p50: 2400 ms, p90: 4300 ms, p99: 6000 ms), latency samples: 104160
Test Ok

github-actions[bot] avatar May 02 '24 19:05 github-actions[bot]