trivial: storage-interface not depend on rocksdb::Error

[msmouse]

Description

as requested in https://github.com/aptos-labs/aptos-core/issues/12451

Type of Change

• [x] Refactoring

Which Components or Systems Does This Change Impact?

• [x] Validator Node

How Has This Been Tested?

build existing coverage

Key Areas to Review

Checklist

• [x] I have read and followed the CONTRIBUTING doc
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I identified and added all stakeholders and component owners affected by this change as reviewers
• [ ] I tested both happy and unhappy path of the functionality
• [ ] I have made corresponding changes to the documentation

[trunk-io[bot]]

⏱️ 8h 16m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
forge-framework-upgrade-test / forge	1h 12m	🟩
rust-smoke-tests	1h 9m	🟩 🟩
execution-performance / single-node-performance	50m	🟩 🟩
rust-targeted-unit-tests	48m	⬜ 🟩 🟩 🟩
windows-build	37m	🟩
rust-unit-tests	29m	🟩
rust-images / rust-all	28m	🟩 🟩
forge-e2e-test / forge	28m	🟩 🟩
forge-compat-test / forge	25m	🟩 🟩
rust-lints	22m	⬜ 🟩 🟩 🟩
run-tests-main-branch	17m	🟩 🟩 🟩 🟩
cli-e2e-tests / run-cli-tests	13m	🟩 🟩
rust-move-tests	13m	⬜ 🟩 🟩 🟩
rust-build-cached-packages	10m	🟩 🟩
check	8m	🟩 🟩
framework-upgrade-determinator	8m	🟩 🟩
general-lints	7m	🟩 🟩 🟩 🟩
check-dynamic-deps	5m	🟩 🟩 🟩 🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose	4m	🟩 🟩
node-api-compatibility-tests / node-api-compatibility-tests	2m	🟩 🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩
file_change_determinator	44s	🟩 🟩 🟩 🟩
file_change_determinator	43s	🟩 🟩 🟩 🟩
execution-performance / file_change_determinator	20s	🟩 🟩
file_change_determinator	19s	🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩
permission-check	11s	🟩 🟩 🟩 🟩
permission-check	11s	🟩 🟩 🟩 🟩
permission-check	9s	🟩 🟩 🟩 🟩
permission-check	6s	🟩 🟩
determine-docker-build-metadata	5s	🟩 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-lints	8m	6m
rust-move-tests	3m	9m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[msmouse]

• #13164 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @msmouse and the rest of your teammates on Graphite

[github-actions[bot]]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite realistic_env_max_load on 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6947 txn/s, latency: 4768 ms, (p50: 4800 ms, p90: 7500 ms, p99: 8100 ms), latency samples: 243160
2. Upgrading first Validator to new version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1778 txn/s, latency: 16394 ms, (p50: 18100 ms, p90: 24000 ms, p99: 24500 ms), latency samples: 88900
3. Upgrading rest of first batch to new version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1583 txn/s, latency: 17716 ms, (p50: 19600 ms, p90: 23500 ms, p99: 23800 ms), latency samples: 83920
4. upgrading second batch to new version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3588 txn/s, latency: 8786 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12900 ms), latency samples: 143520
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite realistic_env_max_load success on 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

two traffics test: inner traffic : committed: 7528 txn/s, latency: 5208 ms, (p50: 5100 ms, p90: 6000 ms, p99: 11100 ms), latency samples: 3252400
two traffics test : committed: 100 txn/s, latency: 1891 ms, (p50: 1800 ms, p90: 2100 ms, p99: 6500 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.202", "QsPosToProposal: max: 0.279, avg: 0.256", "ConsensusProposalToOrdered: max: 0.483, avg: 0.439", "ConsensusOrderedToCommit: max: 0.390, avg: 0.367", "ConsensusProposalToCommit: max: 0.830, avg: 0.806"]
Max round gap was 1 [limit 4] at version 1625464. Max no progress secs was 4.603699 [limit 15] at version 1625464.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite realistic_env_max_load on 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite framework_upgrade on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

Forge is running suite compat on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

• Grafana dashboard (auto-refresh)
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6234 txn/s, latency: 5075 ms, (p50: 4800 ms, p90: 9200 ms, p99: 10800 ms), latency samples: 236920
2. Upgrading first Validator to new version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1467 txn/s, latency: 16354 ms, (p50: 18900 ms, p90: 23800 ms, p99: 26200 ms), latency samples: 88020
3. Upgrading rest of first batch to new version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1772 txn/s, latency: 16287 ms, (p50: 19800 ms, p90: 22600 ms, p99: 23100 ms), latency samples: 88640
4. upgrading second batch to new version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3541 txn/s, latency: 8906 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12800 ms), latency samples: 145200
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite realistic_env_max_load success on 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

two traffics test: inner traffic : committed: 8215 txn/s, latency: 4773 ms, (p50: 4500 ms, p90: 5600 ms, p99: 10200 ms), latency samples: 3549280
two traffics test : committed: 100 txn/s, latency: 1921 ms, (p50: 1900 ms, p90: 2100 ms, p99: 2500 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.210, avg: 0.205", "QsPosToProposal: max: 0.228, avg: 0.212", "ConsensusProposalToOrdered: max: 0.426, avg: 0.413", "ConsensusOrderedToCommit: max: 0.376, avg: 0.367", "ConsensusProposalToCommit: max: 0.790, avg: 0.779"]
Max round gap was 1 [limit 4] at version 1760354. Max no progress secs was 4.648002 [limit 15] at version 1760354.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions[bot]]

:white_check_mark: Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12 (PR)
Upgrade the nodes to version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1424 txn/s, submitted: 1426 txn/s, failed submission: 1 txn/s, expired: 1 txn/s, latency: 2431 ms, (p50: 2100 ms, p90: 4100 ms, p99: 5100 ms), latency samples: 111140
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1214 txn/s, submitted: 1217 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2598 ms, (p50: 2100 ms, p90: 4200 ms, p99: 6200 ms), latency samples: 105700
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12 passed
Upgrade the remaining nodes to version: 3e73d0849e8e03a6fafd8d58fed4fba946cf3b12
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1286 txn/s, submitted: 1288 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2546 ms, (p50: 2100 ms, p90: 4200 ms, p99: 6000 ms), latency samples: 110600
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking