aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

evenly distribute the txn ranges

Open areshand opened this issue 1 year ago • 2 comments

Description

simple and robust. we can always increase the runner when necessary

Type of Change

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Breaking change
  • [x] Performance improvement
  • [ ] Refactoring
  • [ ] Dependency update
  • [ ] Documentation update
  • [ ] Tests

Which Components or Systems Does This Change Impact?

  • [ ] Validator Node
  • [ ] Full Node (API, Indexer, etc.)
  • [ ] Move/Aptos Virtual Machine
  • [ ] Aptos Framework
  • [ ] Aptos CLI/SDK
  • [ ] Developer Infrastructure
  • [x] Other (specify)

How Has This Been Tested?

https://github.com/aptos-labs/aptos-core/actions/runs/8897955533

the run failed due to incompatible changes instead of timeout

Key Areas to Review

Checklist

  • [x] I have read and followed the CONTRIBUTING doc
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [ ] I tested both happy and unhappy path of the functionality
  • [ ] I have made corresponding changes to the documentation

areshand avatar Apr 29 '24 23:04 areshand

⏱️ 121h 10m total CI duration on this PR
Job Cumulative Duration Recent Runs
replay-testnet / replay-verify (17) 12h 🟥
replay-testnet / replay-verify (4) 5h 4m 🟩
replay-mainnet / replay-verify (10) 5h 4m 🟩
replay-mainnet / replay-verify (7) 4h 6m 🟩
replay-mainnet / replay-verify (8) 4h 🟩
replay-mainnet / replay-verify (13) 3h 50m 🟩
replay-mainnet / replay-verify (12) 3h 35m 🟩
replay-mainnet / replay-verify (6) 2h 42m 🟩
replay-mainnet / replay-verify (17) 2h 35m 🟥
replay-mainnet / replay-verify (9) 2h 30m 🟩
replay-mainnet / replay-verify (16) 2h 25m 🟥
replay-mainnet / replay-verify (5) 2h 20m 🟩
replay-testnet / replay-verify (5) 2h 19m 🟩
replay-testnet / replay-verify (15) 2h 17m 🟩
replay-mainnet / replay-verify (11) 2h 16m 🟩
replay-mainnet / replay-verify (14) 2h 16m 🟥
replay-mainnet / replay-verify (15) 2h 16m 🟩
replay-mainnet / replay-verify (4) 2h 16m 🟩
replay-testnet / replay-verify (12) 2h 9m 🟩
replay-testnet / replay-verify (11) 2h 2m 🟩
test-replay / replay-verify (4) 2h 🟥 (+2 more)
test-replay / replay-verify (12) 2h 🟥 (+2 more)
test-replay / replay-verify (15) 2h 🟥 (+2 more)
test-replay / replay-verify (14) 2h 🟥 (+2 more)
test-replay / replay-verify (5) 2h 🟥 (+2 more)
test-replay / replay-verify (11) 2h 🟥 (+2 more)
test-replay / replay-verify (17) 2h 🟥 (+1 more)
test-replay / replay-verify (1) 1h 55m 🟩 (+2 more)
replay-testnet / replay-verify (10) 1h 46m 🟩
replay-testnet / replay-verify (13) 1h 44m 🟩
test-replay / replay-verify (13) 1h 41m 🟩 (+2 more)
replay-testnet / replay-verify (2) 1h 40m 🟩
test-replay / replay-verify (0) 1h 39m 🟩 (+2 more)
replay-testnet / replay-verify (0) 1h 36m 🟩
replay-testnet / replay-verify (16) 1h 34m 🟥
replay-testnet / replay-verify (8) 1h 34m 🟩
test-replay / replay-verify (2) 1h 33m 🟩 (+2 more)
test-replay / replay-verify (10) 1h 33m 🟩 (+2 more)
test-replay / replay-verify (16) 1h 32m 🟥 (+2 more)
replay-testnet / replay-verify (9) 1h 29m 🟩
replay-testnet / replay-verify (14) 1h 26m 🟩
test-replay / replay-verify (8) 1h 26m 🟩 (+2 more)
test-replay / replay-verify (9) 1h 22m 🟩 (+2 more)
replay-testnet / replay-verify (1) 1h 20m 🟩
test-replay / replay-verify (3) 1h 17m 🟩 (+2 more)
replay-testnet / replay-verify (3) 1h 13m 🟩
test-replay / replay-verify (6) 1h 9m 🟩 (+2 more)
replay-testnet / replay-verify (6) 1h 5m 🟩
replay-testnet / replay-verify (7) 1h 5m 🟩
test-replay / replay-verify (7) 1h 1m 🟩 (+2 more)
rust-targeted-unit-tests 59m 🟩 (+2 more)
rust-move-tests 47m 🟩 (+2 more)
replay-mainnet / replay-verify (3) 36m 🟩
rust-lints 34m 🟩🟩 (+2 more)
replay-mainnet / replay-verify (2) 33m 🟩
replay-mainnet / replay-verify (0) 31m 🟩
run-tests-main-branch 29m 🟩🟩🟩🟩🟩 (+2 more)
replay-mainnet / replay-verify (1) 28m 🟩
general-lints 10m 🟥🟥🟥🟥🟩 (+2 more)
check-dynamic-deps 9m 🟩🟩🟩🟩🟩 (+2 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
determine-test-metadata 1m 🟩🟩🟩🟩🟩 (+4 more)
permission-check 21s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 19s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 19s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 18s 🟩🟩🟩🟩🟩 (+1 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-targeted-unit-tests 23m 16m +43%

settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar Apr 29 '24 23:04 trunk-io[bot]

We are abandoning manual ranges? I think we had them because different periods in the history replays at dramatically different speed?

msmouse avatar Apr 30 '24 21:04 msmouse

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jun 16 '24 01:06 github-actions[bot]