[Bug] move-cli crate should be removed

[brmataptos]

🐛 Bug

The move-cli crate is in an inconsistent state and should be removed, which however, requires cutting some upstream dependencies.

For example:

I don't seem able to trigger the tests that are recorded in exp files such as third_party/move/tools/move-cli/tests/build_tests/unbound_dependency/args.evm.exp In particular,

UB=1 cargo test - move-cli

runs other tests, but not the EVM tests.

It seems likely that tests with evm-backend feature are not being run, so probably also the ones corresponding to outputs third_party/move/tools/move-unit-test/tests/test_sources/address_args.evm.exp

[brmataptos]

To regenerate these files, we can run cargo test --features "evm-backend" --test build_testsuite_evm -p move-cli -p move-unit-test but this currently doesn't even compile.

[brmataptos]

After https://github.com/aptos-labs/aptos-core/pull/13125 lands these will at least compile. More work is required to fix the test outputs. Notably, the attribute maps don't seem to be readily available in test_runner.rs. Notably, the compilation process output in third_party/move/tools/move-cli/tests/move_unit_tests/assign_dev_addr_for_dep/args.evm.exp will fail, as we need to pass the dev-addresses defined in Move.toml to the compilation.

[wrwg]

Those tests are dead since a while and the .exp where left there. These are smoke tests for evm integration into the move cli, and not relevant for for testing of the evm compiler. Basically all tests in move-cli are obsolete, the entire crate is deprecated and should be removed, which requires dealing with a few upstream dependencies.

[wrwg]

I reopened and renamed the bug to remove that crate. Lets not invest any time in trying to fix anything here.

[brmataptos]

We should not remove tests until we have equivalent tests in the Aptos world if we have similar functionality. Disassembler, etc. Evm can die, sure.

On Mon, Apr 29, 2024, 11:35 PM Wolfgang Grieskamp @.***> wrote:

I reopened and renamed the bug to remove that crate. Lets not invest any time in trying to fix anything here.

— Reply to this email directly, view it on GitHub https://github.com/aptos-labs/aptos-core/issues/13119#issuecomment-2084482504, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7S3T4YTLZFUL44GVOXYINDY743RZAVCNFSM6AAAAABG7BSOZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUGQ4DENJQGQ . You are receiving this because you authored the thread.Message ID: @.***>

[wrwg]

These tests were deactivated like one year ago or so.

[brmataptos]

The move-cli tests were the only way I was able to reproduce and debug the V2 disassembler problem. We need a replacement.

[github-actions[bot]]

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.