aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

convert UnknownAttribute from a warning into an error

Open brmataptos opened this issue 10 months ago • 6 comments

Description

Convert "Unknown attribute" warning into an error.

Fixes #9411

Type of Change

  • [ ] New feature
  • [X] Bug fix
  • [ ] Breaking change
  • [ ] Performance improvement
  • [ ] Refactoring
  • [ ] Dependency update
  • [ ] Documentation update
  • [ ] Tests

Which Components or Systems Does This Change Impact?

  • [ ] Validator Node
  • [ ] Full Node (API, Indexer, etc.)
  • [X] Move/Aptos Virtual Machine
  • [ ] Aptos Framework
  • [ ] Aptos CLI/SDK
  • [ ] Developer Infrastructure
  • [ ] Other (specify)

How Has This Been Tested?

Usual tests. Warnings have been deployed and tested for a while. This just turns it into an error.

Key Areas to Review

Consider security issues versus user convenience (notably, partners who use their own attributes for some reason). Note that those using their own attributes are probably customizing the code and can disable this.

Checklist

  • [X] I have read and followed the CONTRIBUTING doc
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [X] I tested both happy and unhappy path of the functionality
  • [X] I have made corresponding changes to the functionalitydocumentation

brmataptos avatar Apr 11 '24 22:04 brmataptos