aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[coin <-> FA] Add is_balance_at_least() to not lookup FS if CoinStore has enough for gas

Open igor-aptos opened this issue 10 months ago • 2 comments

During the migration, we can prefer which place to check first (FS or CoinStore), to pay for gas, but if first one has enough resources, we don't need to check for the other one.

This should reduce migration overhead when majority accounts are expected to be on the same resource.

Description

Type of Change

  • [x] New feature

Which Components or Systems Does This Change Impact?

  • [x] Aptos Framework

How Has This Been Tested?

Key Areas to Review

Checklist

  • [ ] I have read and followed the CONTRIBUTING doc
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [ ] I tested both happy and unhappy path of the functionality
  • [ ] I have made corresponding changes to the documentation

igor-aptos avatar Mar 29 '24 21:03 igor-aptos

⏱️ 19h 4m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 4h 32m 🟩
rust-smoke-coverage 3h 51m 🟩
execution-performance / single-node-performance 3h 5m 🟩🟩🟩🟩🟩 (+1 more)
windows-build 1h 55m 🟩🟩🟩🟩🟩 (+1 more)
rust-unit-tests 1h 45m 🟩🟥🟥🟥
rust-move-unit-coverage 1h 16m 🟩🟩🟩🟩
rust-images / rust-all 1h 🟩🟩🟩🟩
rust-lints 33m 🟥🟥🟩🟩
run-tests-main-branch 18m 🟩🟩🟩🟩
check 17m 🟩🟩🟩🟩
check-dynamic-deps 13m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 9m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)
execution-performance / file_change_determinator 2m 🟩🟩🟩🟩🟩 (+1 more)
file_change_determinator 57s 🟩🟩🟩🟩
file_change_determinator 55s 🟩🟩🟩🟩
file_change_determinator 54s 🟩🟩🟩🟩
file_change_determinator 51s 🟩🟩🟩🟩
permission-check 20s 🟩🟩🟩🟩🟩 (+1 more)
permission-check 19s 🟩🟩🟩🟩🟩 (+1 more)
rust-move-tests 15s 🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩
upload-to-codecov 14s 🟩
permission-check 13s 🟩🟩🟩🟩
permission-check 12s 🟩🟩🟩🟩
determine-docker-build-metadata 8s 🟩🟩🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 30m 22m +36%
windows-build 12m 20m -37%
rust-move-tests 5s 3m -97%

settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar Mar 29 '24 21:03 trunk-io[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.1%. Comparing base (663345f) to head (c8ad5d3).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           lightmark/fa_migrate_optimized   #12745     +/-   ##
=================================================================
+ Coverage                            62.7%    64.1%   +1.3%     
=================================================================
  Files                                 820      820             
  Lines                              183573   183193    -380     
=================================================================
+ Hits                               115194   117450   +2256     
+ Misses                              68379    65743   -2636     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 29 '24 22:03 codecov[bot]