aptos-core Bump black from 23.3.0 to 24.3.0 in /testsuite

Bumps black from 23.3.0 to 24.3.0.

Release notes

24.3.0

Highlights

This release is a milestone: it fixes Black's first CVE security vulnerability. If you run Black on untrusted input, or if you habitually put thousands of leading tab characters in your docstrings, you are strongly encouraged to upgrade immediately to fix CVE-2024-21503.

This release also fixes a bug in Black's AST safety check that allowed Black to make incorrect changes to certain f-strings that are valid in Python 3.12 and higher.

Stable style

Don't move comments along with delimiters, which could cause crashes (#4248)

Strengthen AST safety check to catch more unsafe changes to strings. Previous versions of Black would incorrectly format the contents of certain unusual f-strings containing nested strings with the same quote type. Now, Black will crash on such strings until support for the new f-string syntax is implemented. (#4270)

Fix a bug where line-ranges exceeding the last code line would not work as expected (#4273)

Performance

Fix catastrophic performance on docstrings that contain large numbers of leading tab characters. This fixes CVE-2024-21503. (#4278)

Documentation

Note what happens when --check is used with --quiet (#4236)

24.2.0

Stable style

Fixed a bug where comments where mistakenly removed along with redundant parentheses (#4218)

Preview style

Move the hug_parens_with_braces_and_square_brackets feature to the unstable style due to an outstanding crash and proposed formatting tweaks (#4198)

Fixed a bug where base expressions caused inconsistent formatting of ** in tenary expression (#4154)

Checking for newline before adding one on docstring that is almost at the line limit (#4185)

Remove redundant parentheses in case statement if guards (#4214).

Configuration

... (truncated)

Changelog

Sourced from black's changelog.

24.3.0

Highlights

This release is a milestone: it fixes Black's first CVE security vulnerability. If you run Black on untrusted input, or if you habitually put thousands of leading tab characters in your docstrings, you are strongly encouraged to upgrade immediately to fix CVE-2024-21503.

This release also fixes a bug in Black's AST safety check that allowed Black to make incorrect changes to certain f-strings that are valid in Python 3.12 and higher.

Stable style

Don't move comments along with delimiters, which could cause crashes (#4248)

Strengthen AST safety check to catch more unsafe changes to strings. Previous versions of Black would incorrectly format the contents of certain unusual f-strings containing nested strings with the same quote type. Now, Black will crash on such strings until support for the new f-string syntax is implemented. (#4270)

Fix a bug where line-ranges exceeding the last code line would not work as expected (#4273)

Performance

Fix catastrophic performance on docstrings that contain large numbers of leading tab characters. This fixes CVE-2024-21503. (#4278)

Documentation

Note what happens when --check is used with --quiet (#4236)

24.2.0

Stable style

Fixed a bug where comments where mistakenly removed along with redundant parentheses (#4218)

Preview style

Move the hug_parens_with_braces_and_square_brackets feature to the unstable style due to an outstanding crash and proposed formatting tweaks (#4198)

Fixed a bug where base expressions caused inconsistent formatting of ** in tenary expression (#4154)

Checking for newline before adding one on docstring that is almost at the line limit (#4185)

Remove redundant parentheses in case statement if guards (#4214).

... (truncated)

Commits

552baf8 Prepare release 24.3.0 (#4279)
f000936 Fix catastrophic performance in lines_with_leading_tabs_expanded() (#4278)
7b5a657 Fix --line-ranges behavior when ranges are at EOF (#4273)
1abcffc Use regex where we ignore case on windows (#4252)
719e674 Fix 4227: Improve documentation for --quiet --check (#4236)
e5510af update plugin url for Thonny (#4259)
6af7d11 Fix AST safety check false negative (#4270)
f03ee11 Ensure blib2to3.pygram is initialized before use (#4224)
e4bfedb fix: Don't move comments while splitting delimiters (#4248)
d0287e1 Make trailing comma logic more concise (#4202)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

Mar 20 '24 17:03 dependabot[bot]

⏱️ 10h 25m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-unit-coverage	4h 24m	🟩
rust-smoke-coverage	3h 54m	🟩
windows-build	1h 3m	🟩 🟩 🟩
rust-unit-tests	26m	🟩
forge-compat-test / forge	17m	🟥
rust-lints	8m	🟩
check-dynamic-deps	6m	🟩 🟩 🟩
check	4m	🟩
general-lints	2m	🟥
semgrep/ci	52s	🟩
upload-to-codecov	14s	🟩
file_change_determinator	10s	🟩
permission-check	7s	🟥 🟥 🟥
permission-check	6s	🟥 🟥 🟥
permission-check	4s	🟥
permission-check	3s	🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
forge-compat-test / forge	17m	13m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

Mar 20 '24 17:03 trunk-io[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.9%. Comparing base (acb6c89) to head (20d2355). Report is 5 commits behind head on main.

:exclamation: Current head 20d2355 differs from pull request most recent head 3c32e8e

Please upload reports for the commit 3c32e8e to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12610      +/-   ##
==========================================
- Coverage    71.3%    69.9%    -1.5%     
==========================================
  Files        2319     2289      -30     
  Lines      455642   432817   -22825     
==========================================
- Hits       324967   302548   -22419     
+ Misses     130675   130269     -406

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Mar 20 '24 22:03 codecov[bot]

what a surprise, I can't imagine a linter ever landing happily....

Apr 23 '24 06:04 davidiw

Forge is running suite `compat` on `aptos-node-v1.10.1` ==> `95e26e1443c78ca1b7eff741dde2e981cfe24159`

Apr 23 '24 18:04 github-actions[bot]

Forge is running suite `realistic_env_max_load` on `95e26e1443c78ca1b7eff741dde2e981cfe24159`

Apr 23 '24 18:04 github-actions[bot]

:white_check_mark: Forge suite `compat` success on `aptos-node-v1.10.1` ==> `95e26e1443c78ca1b7eff741dde2e981cfe24159`

Compatibility test results for aptos-node-v1.10.1 ==> 95e26e1443c78ca1b7eff741dde2e981cfe24159 (PR)
1. Check liveness of validators at old version: aptos-node-v1.10.1
compatibility::simple-validator-upgrade::liveness-check : committed: 6448 txn/s, latency: 5138 ms, (p50: 4800 ms, p90: 9600 ms, p99: 10200 ms), latency samples: 232140
2. Upgrading first Validator to new version: 95e26e1443c78ca1b7eff741dde2e981cfe24159
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1867 txn/s, latency: 15681 ms, (p50: 19900 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 91520
3. Upgrading rest of first batch to new version: 95e26e1443c78ca1b7eff741dde2e981cfe24159
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1707 txn/s, latency: 16720 ms, (p50: 19500 ms, p90: 24100 ms, p99: 24600 ms), latency samples: 92180
4. upgrading second batch to new version: 95e26e1443c78ca1b7eff741dde2e981cfe24159
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3423 txn/s, latency: 9389 ms, (p50: 9800 ms, p90: 12700 ms, p99: 13000 ms), latency samples: 143780
5. check swarm health
Compatibility test for aptos-node-v1.10.1 ==> 95e26e1443c78ca1b7eff741dde2e981cfe24159 passed
Test Ok

Apr 23 '24 19:04 github-actions[bot]

:white_check_mark: Forge suite `realistic_env_max_load` success on `95e26e1443c78ca1b7eff741dde2e981cfe24159`

two traffics test: inner traffic : committed: 7944 txn/s, latency: 4937 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10200 ms), latency samples: 3432160
two traffics test : committed: 100 txn/s, latency: 1928 ms, (p50: 1900 ms, p90: 2100 ms, p99: 4800 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.209, avg: 0.206", "QsPosToProposal: max: 0.248, avg: 0.226", "ConsensusProposalToOrdered: max: 0.437, avg: 0.416", "ConsensusOrderedToCommit: max: 0.378, avg: 0.365", "ConsensusProposalToCommit: max: 0.794, avg: 0.780"]
Max round gap was 1 [limit 4] at version 1704640. Max no progress secs was 4.7677507 [limit 15] at version 1704640.
Test Ok

Apr 23 '24 19:04 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

Jun 08 '24 01:06 github-actions[bot]