aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

brian/experiment high tps qs debug

Open bchocho opened this issue 1 year ago • 6 comments

  • High throughput experiment
  • Reduce block size and mempool backlog
  • Block size 10k
  • Mempool backlog to 150k
  • mempool backlog to 90k
  • mempool backlog to 100k
  • Disable shuffling
  • Revert "Disable shuffling"
  • Disable waiting for full block
  • Increase block size
  • QS increase backpressure tps
  • Increase mempool backlog a bit and dial back the block size
  • Increase the bounded executor capacity
  • Test comment out verify txns
  • Improve visibility
  • Improve visibility
  • comment verification
  • Add more metrics
  • Disable sync up
  • Revert "Disable sync up"
  • Shuffle peers
  • Round robin leader election
  • Revert "Round robin leader election"
  • Disable delayed qc aggregation
  • Increase the mempool backlog
  • Block size
  • Mempool backlog to 200k
  • mempool backlog to 170k
  • Mempool backlog to 160k
  • [Quorum Store] improvements to prevent some batches not getting quorum #11629

Description

Test Plan

bchocho avatar Jan 26 '24 19:01 bchocho

⏱️ 9h 40m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 4h 35m 🟩
rust-smoke-coverage 3h 7m 🟩
windows-build 50m 🟩🟩
rust-unit-tests 30m 🟩
rust-images / rust-all 12m 🟩
rust-lints 9m 🟥
check 4m 🟩
check-dynamic-deps 4m 🟩🟩
run-tests-main-branch 4m 🟥
general-lints 3m 🟩
semgrep/ci 47s 🟩🟩
file_change_determinator 21s 🟩
upload-to-codecov 15s 🟩
file_change_determinator 12s 🟩
file_change_determinator 8s 🟩
permission-check 5s 🟩🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
permission-check 3s 🟩
determine-docker-build-metadata 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
windows-build 26m 19m +38%

settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar Jan 26 '24 19:01 trunk-io[bot]

Codecov Report

Attention: Patch coverage is 45.04505% with 61 lines in your changes missing coverage. Please review.

Project coverage is 69.7%. Comparing base (214dcce) to head (5a71dbb). Report is 2346 commits behind head on main.

Files with missing lines Patch % Lines
consensus/consensus-types/src/proof_of_store.rs 0.0% 22 Missing :warning:
consensus/src/quorum_store/proof_coordinator.rs 31.8% 15 Missing :warning:
consensus/src/round_manager.rs 55.1% 13 Missing :warning:
consensus/src/quorum_store/counters.rs 0.0% 9 Missing :warning:
consensus/src/consensus_provider.rs 0.0% 1 Missing :warning:
consensus/src/quorum_store/quorum_store_builder.rs 0.0% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #11798     +/-   ##
=========================================
  Coverage    69.6%    69.7%             
=========================================
  Files        2116     2172     +56     
  Lines      401742   409601   +7859     
=========================================
+ Hits       279974   285706   +5732     
- Misses     121768   123895   +2127     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 26 '24 23:01 codecov[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Apr 05 '24 01:04 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar May 21 '24 01:05 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jul 06 '24 01:07 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Aug 22 '24 01:08 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Oct 07 '24 02:10 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Nov 22 '24 02:11 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jan 08 '25 02:01 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Feb 24 '25 02:02 github-actions[bot]