aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Compiler V2] [Bugfix] Fix 11379

Open fEst1ck opened this issue 2 years ago • 2 comments

Description

Closes #11379 by changing the implementation of is_borrowed.

Test Plan

Existing tests, especially ability-checker/ability_violation.move which triggered the debug assertion before.

fEst1ck avatar Dec 22 '23 05:12 fEst1ck

⏱️ 1h 29m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 30m 🟩
rust-move-unit-coverage 20m 🟩
windows-build 16m 🟩
run-tests-main-branch 8m 🟩🟩
rust-lints 6m 🟥
check 4m 🟩
general-lints 2m 🟩
check-dynamic-deps 2m 🟩
file_change_determinator 25s 🟩🟩
semgrep/ci 17s 🟩
permission-check 13s 🟩🟩
file_change_determinator 9s 🟩
permission-check 6s 🟩🟩
permission-check 6s 🟩🟩
permission-check 4s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar Dec 22 '23 05:12 trunk-io[bot]

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.9%. Comparing base (8b42857) to head (530ec01). Report is 834 commits behind head on main.

:exclamation: Current head 530ec01 differs from pull request most recent head 4910745

Please upload reports for the commit 4910745 to get more accurate results.

Files Patch % Lines
...ove/move-compiler-v2/src/pipeline/explicit_drop.rs 60.0% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #11486     +/-   ##
=========================================
- Coverage    69.0%    68.9%   -0.1%     
=========================================
  Files         767      767             
  Lines      178536   178531      -5     
=========================================
- Hits       123208   123184     -24     
- Misses      55328    55347     +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 22 '23 05:12 codecov[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Apr 05 '24 01:04 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar May 21 '24 01:05 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jul 06 '24 01:07 github-actions[bot]