aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

subscribable event filter

Open zjma opened this issue 1 year ago • 14 comments
trafficstars

Description

Test Plan

zjma avatar Dec 20 '23 08:12 zjma

⏱️ 18h 9m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 7h 2m 🟩
rust-smoke-coverage 3h 19m 🟩
forge-framework-upgrade-test / forge 1h 25m 🟥🟩
rust-unit-tests 1h 14m 🟩🟩
rust-smoke-tests 1h 3m 🟩🟩
windows-build 58m 🟩🟩🟩
execution-performance / single-node-performance 38m 🟩🟩
forge-e2e-test / forge 30m 🟩🟩
forge-compat-test / forge 26m 🟩🟩
rust-images / rust-all 20m 🟩🟩
cli-e2e-tests / run-cli-tests 20m 🟩🟩
rust-lints 16m 🟥🟥
run-tests-main-branch 9m 🟩🟩
check 8m 🟩🟩
check-dynamic-deps 8m 🟩🟩🟩
general-lints 6m 🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 3m 🟥🟥
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 30s 🟩🟩
file_change_determinator 29s 🟩🟩🟩
file_change_determinator 21s 🟩🟩
execution-performance / file_change_determinator 19s 🟩🟩
execution-performance / parallel-execution-performance 17s 🟩🟩
execution-performance / sequential-execution-performance 15s 🟩🟩
upload-to-codecov 12s 🟩
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩
permission-check 6s 🟩🟩🟩
permission-check 6s 🟩🟩🟩
permission-check 4s 🟩🟩
determine-docker-build-metadata 3s 🟩🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-unit-coverage 7h 2m 4h 12m +68%
windows-build 26m 17m +50%
rust-unit-tests 40m 33m +24%

settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar Dec 20 '23 08:12 trunk-io[bot]

Forge is running suite realistic_env_max_load on c2e83f12947ad0ac80df747bfa1f65f65ce22a06

github-actions[bot] avatar Dec 20 '23 08:12 github-actions[bot]

Forge is running suite framework_upgrade on aptos-node-v1.8.3 ==> c2e83f12947ad0ac80df747bfa1f65f65ce22a06

github-actions[bot] avatar Dec 20 '23 08:12 github-actions[bot]

Forge is running suite compat on aptos-node-v1.8.3 ==> c2e83f12947ad0ac80df747bfa1f65f65ce22a06

github-actions[bot] avatar Dec 20 '23 08:12 github-actions[bot]

:white_check_mark: Forge suite compat success on aptos-node-v1.8.3 ==> c2e83f12947ad0ac80df747bfa1f65f65ce22a06

Compatibility test results for aptos-node-v1.8.3 ==> c2e83f12947ad0ac80df747bfa1f65f65ce22a06 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4573 txn/s, latency: 7022 ms, (p50: 7100 ms, p90: 10200 ms, p99: 15400 ms), latency samples: 173800
2. Upgrading first Validator to new version: c2e83f12947ad0ac80df747bfa1f65f65ce22a06
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1767 txn/s, latency: 15919 ms, (p50: 19500 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 91920
3. Upgrading rest of first batch to new version: c2e83f12947ad0ac80df747bfa1f65f65ce22a06
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1778 txn/s, latency: 15836 ms, (p50: 19300 ms, p90: 21800 ms, p99: 22600 ms), latency samples: 92500
4. upgrading second batch to new version: c2e83f12947ad0ac80df747bfa1f65f65ce22a06
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3682 txn/s, latency: 8747 ms, (p50: 9900 ms, p90: 12300 ms, p99: 12700 ms), latency samples: 143620
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> c2e83f12947ad0ac80df747bfa1f65f65ce22a06 passed
Test Ok

github-actions[bot] avatar Dec 20 '23 09:12 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on c2e83f12947ad0ac80df747bfa1f65f65ce22a06

two traffics test: inner traffic : committed: 7064 txn/s, submitted: 7068 txn/s, expired: 3 txn/s, latency: 5064 ms, (p50: 4800 ms, p90: 6300 ms, p99: 9800 ms), latency samples: 3299041
two traffics test : committed: 100 txn/s, latency: 2233 ms, (p50: 2200 ms, p90: 2700 ms, p99: 3200 ms), latency samples: 1980
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.207, avg: 0.196", "QsPosToProposal: max: 0.166, avg: 0.157", "ConsensusProposalToOrdered: max: 0.600, avg: 0.566", "ConsensusOrderedToCommit: max: 0.579, avg: 0.519", "ConsensusProposalToCommit: max: 1.135, avg: 1.086"]
Max round gap was 1 [limit 4] at version 1485714. Max no progress secs was 4.297961 [limit 10] at version 1485714.
Test Ok

github-actions[bot] avatar Dec 20 '23 09:12 github-actions[bot]

:x: Forge suite framework_upgrade failure on aptos-node-v1.8.3 ==> c2e83f12947ad0ac80df747bfa1f65f65ce22a06

Compatibility test results for aptos-node-v1.8.3 ==> c2e83f12947ad0ac80df747bfa1f65f65ce22a06 (PR)
Upgrade the nodes to version: c2e83f12947ad0ac80df747bfa1f65f65ce22a06
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-11440.svc:8080/v1/estimate_gas_price): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: __libc_start_main
  13: <unknown>
Trailing Log Lines:
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: __libc_start_main
  13: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at testsuite/forge/src/backend/k8s/swarm.rs:676:18:
called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-11440" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-11440\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-11440" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

github-actions[bot] avatar Dec 20 '23 09:12 github-actions[bot]

Forge is running suite framework_upgrade on aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240

github-actions[bot] avatar Dec 20 '23 15:12 github-actions[bot]

Forge is running suite realistic_env_max_load on b183cb8956543f81d4d90f84c5a24a1afb505240

github-actions[bot] avatar Dec 20 '23 15:12 github-actions[bot]

Forge is running suite compat on aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240

github-actions[bot] avatar Dec 20 '23 15:12 github-actions[bot]

:white_check_mark: Forge suite compat success on aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240

Compatibility test results for aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3789 txn/s, latency: 6360 ms, (p50: 6300 ms, p90: 9500 ms, p99: 12200 ms), latency samples: 189460
2. Upgrading first Validator to new version: b183cb8956543f81d4d90f84c5a24a1afb505240
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1620 txn/s, latency: 15665 ms, (p50: 18900 ms, p90: 22000 ms, p99: 22400 ms), latency samples: 92360
3. Upgrading rest of first batch to new version: b183cb8956543f81d4d90f84c5a24a1afb505240
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1575 txn/s, latency: 17371 ms, (p50: 19500 ms, p90: 24400 ms, p99: 25800 ms), latency samples: 80360
4. upgrading second batch to new version: b183cb8956543f81d4d90f84c5a24a1afb505240
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1946 txn/s, latency: 9162 ms, (p50: 9000 ms, p90: 12100 ms, p99: 38100 ms), latency samples: 140140
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240 passed
Test Ok

github-actions[bot] avatar Dec 20 '23 15:12 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on b183cb8956543f81d4d90f84c5a24a1afb505240

two traffics test: inner traffic : committed: 7116 txn/s, submitted: 7119 txn/s, expired: 3 txn/s, latency: 4846 ms, (p50: 4500 ms, p90: 5900 ms, p99: 9900 ms), latency samples: 3444367
two traffics test : committed: 100 txn/s, latency: 2239 ms, (p50: 2200 ms, p90: 2700 ms, p99: 3000 ms), latency samples: 1960
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.209, avg: 0.197", "QsPosToProposal: max: 0.147, avg: 0.142", "ConsensusProposalToOrdered: max: 0.598, avg: 0.568", "ConsensusOrderedToCommit: max: 0.571, avg: 0.539", "ConsensusProposalToCommit: max: 1.140, avg: 1.108"]
Max round gap was 1 [limit 4] at version 1722355. Max no progress secs was 4.429638 [limit 10] at version 1722355.
Test Ok

github-actions[bot] avatar Dec 20 '23 15:12 github-actions[bot]

:white_check_mark: Forge suite framework_upgrade success on aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240

Compatibility test results for aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240 (PR)
Upgrade the nodes to version: b183cb8956543f81d4d90f84c5a24a1afb505240
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4528 txn/s, latency: 4942 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9300 ms), latency samples: 235480
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> b183cb8956543f81d4d90f84c5a24a1afb505240 passed
Test Ok

github-actions[bot] avatar Dec 20 '23 15:12 github-actions[bot]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4e869e5) 68.8% compared to head (c2e83f1) 69.7%. Report is 3 commits behind head on main.

:exclamation: Current head c2e83f1 differs from pull request most recent head b183cb8. Consider uploading reports for the commit b183cb8 to get more accurate results

Files Patch % Lines
aptos-move/e2e-move-tests/src/harness.rs 80.0% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #11440       +/-   ##
===========================================
+ Coverage    68.8%    69.7%     +0.8%     
===========================================
  Files         767     2084     +1317     
  Lines      178259   398769   +220510     
===========================================
+ Hits       122731   278137   +155406     
- Misses      55528   120632    +65104     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 20 '23 15:12 codecov[bot]