aptos-core
aptos-core copied to clipboard

Published 20 hours ago •

Reame
Issues

aptos-move/block-executor/src: typo fix

Open Gakunt opened this issue 1 year ago • 1 comments

Description

I found out a few typos, some are comments, some are not.

Test Plan

This is a minor change that doesn't require testing or changelog entry.

Dec 16 '23 02:12 Gakunt

⏱️ 40m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
windows-build	21m	🟩
rust-lints	9m	🟩
check	4m	🟩
general-lints	3m	🟩
check-dynamic-deps	2m	🟩
semgrep/ci	22s	🟩
file_change_determinator	12s	🟩
permission-check	3s	🟥
permission-check	2s	🟥
permission-check	2s	🟥
permission-check	2s	🟥

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

Dec 16 '23 02:12 trunk-io[bot]

Forge is running suite `realistic_env_max_load` on `2df93435f25285cb4a0ae3f582628308b709536e`

Jan 21 '24 14:01 github-actions[bot]

Forge is running suite `framework_upgrade` on `aptos-node-v1.8.3` ==> `2df93435f25285cb4a0ae3f582628308b709536e`

Jan 21 '24 14:01 github-actions[bot]

Forge is running suite `compat` on `aptos-node-v1.8.3` ==> `2df93435f25285cb4a0ae3f582628308b709536e`

Jan 21 '24 14:01 github-actions[bot]

:x: Forge suite `realistic_env_max_load` failure on `2df93435f25285cb4a0ae3f582628308b709536e`

two traffics test: inner traffic : committed: 6759 txn/s, latency: 5652 ms, (p50: 5100 ms, p90: 7800 ms, p99: 15300 ms), latency samples: 2926880
Test Failed: test NetworkLoadTest

Caused by:
    TPS requirement for inner traffic failed. Average TPS 6759, minimum TPS requirement 7000. Full stats: committed: 6759 txn/s, latency: 5652 ms, (p50: 5100 ms, p90: 7800 ms, p99: 15300 ms), latency samples: 2926880

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>
Trailing Log Lines:
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>


Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:292"},"thread_name":"main","hostname":"forge-e2e-pr-11375-1705848218-2df93435f25285cb4a0ae3f582628308b","timestamp":"2024-01-21T14:54:23.024116Z","message":"Deleting namespace forge-e2e-pr-11375: Some(NamespaceStatus { conditions: None, phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:400"},"thread_name":"main","hostname":"forge-e2e-pr-11375-1705848218-2df93435f25285cb4a0ae3f582628308b","timestamp":"2024-01-21T14:54:23.024150Z","message":"aptos-node resources for Forge removed in namespace: forge-e2e-pr-11375"}

failures:
    CompositeNetworkTest

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: __libc_start_main
   7: <unknown>
Debugging output:
NAME                                    READY   STATUS      RESTARTS   AGE
aptos-node-0-fullnode-eforge237-0       1/1     Running     0          10m
aptos-node-0-validator-0                1/1     Running     0          10m
aptos-node-1-fullnode-eforge237-0       1/1     Running     0          10m
aptos-node-1-validator-0                1/1     Running     0          10m
aptos-node-2-fullnode-eforge237-0       1/1     Running     0          10m
aptos-node-2-validator-0                1/1     Running     0          10m
aptos-node-3-fullnode-eforge237-0       1/1     Running     0          10m
aptos-node-3-validator-0                1/1     Running     0          10m
aptos-node-4-fullnode-eforge237-0       1/1     Running     0          10m
aptos-node-4-validator-0                1/1     Running     0          10m
aptos-node-5-validator-0                1/1     Running     0          10m
aptos-node-6-validator-0                1/1     Running     0          10m
genesis-aptos-genesis-eforge237-ffflq   0/1     Completed   0          10m

Jan 21 '24 14:01 github-actions[bot]

:white_check_mark: Forge suite `compat` success on `aptos-node-v1.8.3` ==> `2df93435f25285cb4a0ae3f582628308b709536e`

Compatibility test results for aptos-node-v1.8.3 ==> 2df93435f25285cb4a0ae3f582628308b709536e (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5207 txn/s, latency: 6364 ms, (p50: 6600 ms, p90: 9000 ms, p99: 9300 ms), latency samples: 187480
2. Upgrading first Validator to new version: 2df93435f25285cb4a0ae3f582628308b709536e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1774 txn/s, latency: 15971 ms, (p50: 19000 ms, p90: 22000 ms, p99: 22400 ms), latency samples: 92280
3. Upgrading rest of first batch to new version: 2df93435f25285cb4a0ae3f582628308b709536e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1780 txn/s, latency: 15742 ms, (p50: 19000 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 92600
4. upgrading second batch to new version: 2df93435f25285cb4a0ae3f582628308b709536e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3585 txn/s, latency: 9001 ms, (p50: 9900 ms, p90: 13300 ms, p99: 13600 ms), latency samples: 139820
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 2df93435f25285cb4a0ae3f582628308b709536e passed
Test Ok

Jan 21 '24 14:01 github-actions[bot]

:x: Forge suite `framework_upgrade` failure on `aptos-node-v1.8.3` ==> `2df93435f25285cb4a0ae3f582628308b709536e`

Compatibility test results for aptos-node-v1.8.3 ==> 2df93435f25285cb4a0ae3f582628308b709536e (PR)
Upgrade the nodes to version: 2df93435f25285cb4a0ae3f582628308b709536e
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-11375.svc:8080/v1/accounts/0000000000000000000000000000000000000000000000000000000000000001/resource/0x1::block::BlockResource): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>
Trailing Log Lines:
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at testsuite/forge/src/backend/k8s/swarm.rs:696:18:
called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-11375" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-11375\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-11375" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: __libc_start_main
  16: <unknown>
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

Jan 21 '24 15:01 github-actions[bot]