aptos-core
aptos-core copied to clipboard
[Transaction] rename UserTransaction/SignedTransaction/RawTransaction…
… to Deprecated*
Description
step 1 to support new txn type
Test Plan
n/a
Codecov Report
Attention: Patch coverage is 60.75949%
with 93 lines
in your changes are missing coverage. Please review.
Project coverage is 68.6%. Comparing base (
409779a
) to head (9c9309c
). Report is 657 commits behind head on main.
:exclamation: Current head 9c9309c differs from pull request most recent head 7cc36d3. Consider uploading reports for the commit 7cc36d3 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #11027 +/- ##
=========================================
- Coverage 68.8% 68.6% -0.2%
=========================================
Files 775 754 -21
Lines 178229 172319 -5910
=========================================
- Hits 122677 118340 -4337
+ Misses 55552 53979 -1573
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This issue is stale because it has been open 45 days with no activity. Remove the stale
label, comment or push a commit - otherwise this will be closed in 15 days.
I presume this will be backwards compatible?
I presume this will be backwards compatible?
in what sense?
I presume this will be backwards compatible?
in what sense?
In the sense that we are keeping the old structs around. So this is not a "rename"; it's adding new V2 structs, no?
I presume this will be backwards compatible?
in what sense?
In the sense that we are keeping the old structs around. So this is not a "rename"; it's adding new V2 structs, no?
Yes.
We have to support the old format but I guess it will be wrapped into the new enum as a V0
version.
This issue is stale because it has been open 45 days with no activity. Remove the stale
label, comment or push a commit - otherwise this will be closed in 15 days.