aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Transaction] rename UserTransaction/SignedTransaction/RawTransaction…

Open lightmark opened this issue 1 year ago • 7 comments

… to Deprecated*

Description

step 1 to support new txn type

Test Plan

n/a

lightmark avatar Nov 21 '23 20:11 lightmark

Codecov Report

Attention: Patch coverage is 60.75949% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 68.6%. Comparing base (409779a) to head (9c9309c). Report is 657 commits behind head on main.

:exclamation: Current head 9c9309c differs from pull request most recent head 7cc36d3. Consider uploading reports for the commit 7cc36d3 to get more accurate results

Files Patch % Lines
types/src/transaction/mod.rs 32.4% 25 Missing :warning:
types/src/transaction/authenticator.rs 26.6% 11 Missing :warning:
aptos-move/aptos-vm/src/aptos_vm.rs 28.5% 10 Missing :warning:
aptos-move/e2e-move-tests/src/aggregator_v2.rs 84.1% 10 Missing :warning:
...-tests/src/execution_strategies/guided_strategy.rs 0.0% 8 Missing :warning:
aptos-move/e2e-tests/src/executor.rs 64.2% 5 Missing :warning:
...e-tests/src/execution_strategies/basic_strategy.rs 0.0% 4 Missing :warning:
...-tests/src/execution_strategies/random_strategy.rs 0.0% 4 Missing :warning:
.../src/transaction/signature_verified_transaction.rs 33.3% 4 Missing :warning:
.../e2e-tests/src/account_universe/bad_transaction.rs 0.0% 3 Missing :warning:
... and 6 more
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #11027     +/-   ##
=========================================
- Coverage    68.8%    68.6%   -0.2%     
=========================================
  Files         775      754     -21     
  Lines      178229   172319   -5910     
=========================================
- Hits       122677   118340   -4337     
+ Misses      55552    53979   -1573     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 21 '23 20:11 codecov[bot]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Jan 06 '24 01:01 github-actions[bot]

I presume this will be backwards compatible?

alinush avatar Mar 13 '24 22:03 alinush

I presume this will be backwards compatible?

in what sense?

lightmark avatar Mar 14 '24 04:03 lightmark

I presume this will be backwards compatible?

in what sense?

In the sense that we are keeping the old structs around. So this is not a "rename"; it's adding new V2 structs, no?

alinush avatar Mar 14 '24 23:03 alinush

I presume this will be backwards compatible?

in what sense?

In the sense that we are keeping the old structs around. So this is not a "rename"; it's adding new V2 structs, no?

Yes. We have to support the old format but I guess it will be wrapped into the new enum as a V0 version.

lightmark avatar Mar 14 '24 23:03 lightmark

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

github-actions[bot] avatar Apr 29 '24 01:04 github-actions[bot]