aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Multisig][CLI][Compiler] Different CLI versions generate different multisig v2 transaction proposals

Open alnoki opened this issue 2 years ago • 1 comments

@banool @wrwg @movekevin @vgao1996 @davidiw

Description of problem

The following sequence results in different output when run on CLI v2.1.0 versus v2.3.0:

wait=5 && echo
echo This script waits $wait seconds between commands && echo && sleep $wait
echo && echo Setting multisig address && echo && sleep $wait
addr=0xc0deb00c405f84c85dc13442e305df75d1288100cdd82675695f6148c7ece51c
echo && echo Multisig address set to $addr && echo && sleep $wait
echo && echo Creating temporary directory && echo && sleep $wait
tmp_dir=$(mktemp -d)
echo && echo New temporary directory at $tmp_dir && echo && sleep $wait
echo && echo Cloning Econia into temporary directory && echo && sleep $wait
cd $tmp_dir
git clone https://github.com/econia-labs/econia.git \
	--branch v4.2.0-audited --depth 1
cd econia/src/move/econia
echo && echo Build publication payload from source && echo && sleep $wait
aptos move build-publish-payload \
	--assume-yes \
	--included-artifacts none \
	--json-output-file publication.json \
	--named-addresses econia=$addr \
	--override-size-check

This is a problem when verifying multisig package publication on-chain:

echo && echo Verify payload in on-chain proposal && echo && sleep $wait
aptos multisig verify-proposal \
  --json-file publication.json \
  --multisig-address $addr \
  --sequence-number 9 \
  --url https://fullnode.mainnet.aptoslabs.com
echo && echo Removing temporary directory && echo && sleep $wait
cd ~ && rm -rf $tmp_dir

because a transaction mismatch may be reported if multisig proposer and verifier are using different CLI versions.

alnoki avatar Nov 15 '23 22:11 alnoki

Bspsrc itself shouldn't make any network connections. However, the Java runtime it relies on might be checking for updates or performing other routine tasks that require a network connection (There really shouldn't be any, but who knows).

I checked on my PC and did not observe any network traffic when launching bspinfo/bspsrc. Could you provide more details on the type of traffic you detected and how you identified it?

rihi avatar May 17 '24 18:05 rihi