aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[event v2] double emitting in account, coin, fungible asset and object and migrate move-examples

Open lightmark opened this issue 1 year ago • 55 comments

Description

step 1 of #10529 leave other modules for grabs.

Test Plan

ut

lightmark avatar Oct 16 '23 22:10 lightmark

Forge is running suite compat on aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc

github-actions[bot] avatar Nov 06 '23 22:11 github-actions[bot]

Forge is running suite framework_upgrade on aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc

github-actions[bot] avatar Nov 06 '23 22:11 github-actions[bot]

Forge is running suite realistic_env_max_load on f7f0134d74dd9774781679f303ed5ee66d7582dc

github-actions[bot] avatar Nov 06 '23 22:11 github-actions[bot]

:white_check_mark: Forge suite compat success on aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc

Compatibility test results for aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5393 txn/s, latency: 6191 ms, (p50: 6300 ms, p90: 8700 ms, p99: 12300 ms), latency samples: 188760
2. Upgrading first Validator to new version: f7f0134d74dd9774781679f303ed5ee66d7582dc
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1771 txn/s, latency: 16087 ms, (p50: 19000 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92100
3. Upgrading rest of first batch to new version: f7f0134d74dd9774781679f303ed5ee66d7582dc
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1871 txn/s, latency: 15655 ms, (p50: 19100 ms, p90: 22100 ms, p99: 22500 ms), latency samples: 91700
4. upgrading second batch to new version: f7f0134d74dd9774781679f303ed5ee66d7582dc
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3334 txn/s, latency: 9599 ms, (p50: 9900 ms, p90: 13200 ms, p99: 17300 ms), latency samples: 130040
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc passed
Test Ok

github-actions[bot] avatar Nov 06 '23 23:11 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on f7f0134d74dd9774781679f303ed5ee66d7582dc

two traffics test: inner traffic : committed: 8496 txn/s, latency: 4619 ms, (p50: 4500 ms, p90: 5400 ms, p99: 10500 ms), latency samples: 3670300
two traffics test : committed: 100 txn/s, latency: 2219 ms, (p50: 2100 ms, p90: 2600 ms, p99: 6200 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.196", "QsPosToProposal: max: 0.148, avg: 0.137", "ConsensusProposalToOrdered: max: 0.582, avg: 0.552", "ConsensusOrderedToCommit: max: 0.554, avg: 0.512", "ConsensusProposalToCommit: max: 1.121, avg: 1.064"]
Max round gap was 1 [limit 4] at version 1865855. Max no progress secs was 4.431394 [limit 10] at version 1865855.
Test Ok

github-actions[bot] avatar Nov 06 '23 23:11 github-actions[bot]

:white_check_mark: Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc

Compatibility test results for aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc (PR)
Upgrade the nodes to version: f7f0134d74dd9774781679f303ed5ee66d7582dc
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 6959 txn/s, latency: 4790 ms, (p50: 4800 ms, p90: 7500 ms, p99: 8100 ms), latency samples: 243580
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> f7f0134d74dd9774781679f303ed5ee66d7582dc passed
Test Ok

github-actions[bot] avatar Nov 06 '23 23:11 github-actions[bot]

Forge is running suite realistic_env_max_load on 88530f2777b49ebd2d32a54be3f34fdc6edbdeed

github-actions[bot] avatar Nov 08 '23 22:11 github-actions[bot]

Forge is running suite compat on aptos-node-v1.7.3 ==> 88530f2777b49ebd2d32a54be3f34fdc6edbdeed

github-actions[bot] avatar Nov 08 '23 22:11 github-actions[bot]

Forge is running suite framework_upgrade on aptos-node-v1.7.3 ==> 88530f2777b49ebd2d32a54be3f34fdc6edbdeed

github-actions[bot] avatar Nov 08 '23 22:11 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on 88530f2777b49ebd2d32a54be3f34fdc6edbdeed

two traffics test: inner traffic : committed: 7630 txn/s, latency: 5127 ms, (p50: 5000 ms, p90: 6300 ms, p99: 10800 ms), latency samples: 3311640
two traffics test : committed: 100 txn/s, latency: 2182 ms, (p50: 2100 ms, p90: 2600 ms, p99: 2900 ms), latency samples: 1840
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.209, avg: 0.196", "QsPosToProposal: max: 0.177, avg: 0.160", "ConsensusProposalToOrdered: max: 0.647, avg: 0.597", "ConsensusOrderedToCommit: max: 0.544, avg: 0.512", "ConsensusProposalToCommit: max: 1.188, avg: 1.109"]
Max round gap was 1 [limit 4] at version 1661439. Max no progress secs was 3.944124 [limit 10] at version 1661439.
Test Ok

github-actions[bot] avatar Nov 08 '23 22:11 github-actions[bot]

:white_check_mark: Forge suite compat success on aptos-node-v1.7.3 ==> 88530f2777b49ebd2d32a54be3f34fdc6edbdeed

Compatibility test results for aptos-node-v1.7.3 ==> 88530f2777b49ebd2d32a54be3f34fdc6edbdeed (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4885 txn/s, latency: 6624 ms, (p50: 6300 ms, p90: 9600 ms, p99: 16400 ms), latency samples: 185660
2. Upgrading first Validator to new version: 88530f2777b49ebd2d32a54be3f34fdc6edbdeed
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1782 txn/s, latency: 16205 ms, (p50: 19200 ms, p90: 22100 ms, p99: 22600 ms), latency samples: 92680
3. Upgrading rest of first batch to new version: 88530f2777b49ebd2d32a54be3f34fdc6edbdeed
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1592 txn/s, latency: 17569 ms, (p50: 19600 ms, p90: 22100 ms, p99: 22700 ms), latency samples: 82800
4. upgrading second batch to new version: 88530f2777b49ebd2d32a54be3f34fdc6edbdeed
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3687 txn/s, latency: 8768 ms, (p50: 9900 ms, p90: 12000 ms, p99: 12300 ms), latency samples: 143800
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 88530f2777b49ebd2d32a54be3f34fdc6edbdeed passed
Test Ok

github-actions[bot] avatar Nov 08 '23 22:11 github-actions[bot]

:x: Forge suite framework_upgrade failure on aptos-node-v1.7.3 ==> 88530f2777b49ebd2d32a54be3f34fdc6edbdeed

Compatibility test results for aptos-node-v1.7.3 ==> 88530f2777b49ebd2d32a54be3f34fdc6edbdeed (PR)
Upgrade the nodes to version: 88530f2777b49ebd2d32a54be3f34fdc6edbdeed
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-10532.svc:8080/v1/estimate_gas_price): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>
Trailing Log Lines:
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-10532" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-10532\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-10532" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: __libc_start_main
  16: <unknown>', testsuite/forge/src/backend/k8s/swarm.rs:676:18
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

github-actions[bot] avatar Nov 08 '23 23:11 github-actions[bot]

Forge is running suite framework_upgrade on aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd

github-actions[bot] avatar Nov 13 '23 19:11 github-actions[bot]

Forge is running suite realistic_env_max_load on d0b921dc483f434faa12204dc6be11923c530bdd

github-actions[bot] avatar Nov 13 '23 19:11 github-actions[bot]

Forge is running suite compat on aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd

github-actions[bot] avatar Nov 13 '23 19:11 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on d0b921dc483f434faa12204dc6be11923c530bdd

two traffics test: inner traffic : committed: 7914 txn/s, submitted: 7929 txn/s, expired: 14 txn/s, latency: 4587 ms, (p50: 4200 ms, p90: 5700 ms, p99: 10500 ms), latency samples: 3537861
two traffics test : committed: 100 txn/s, latency: 2269 ms, (p50: 2200 ms, p90: 2600 ms, p99: 6400 ms), latency samples: 1900
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.238, avg: 0.200", "QsPosToProposal: max: 0.164, avg: 0.145", "ConsensusProposalToOrdered: max: 0.595, avg: 0.547", "ConsensusOrderedToCommit: max: 0.558, avg: 0.529", "ConsensusProposalToCommit: max: 1.107, avg: 1.076"]
Max round gap was 1 [limit 4] at version 1611442. Max no progress secs was 4.195304 [limit 10] at version 1611442.
Test Ok

github-actions[bot] avatar Nov 13 '23 19:11 github-actions[bot]

:white_check_mark: Forge suite compat success on aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd

Compatibility test results for aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4882 txn/s, latency: 6672 ms, (p50: 6600 ms, p90: 9900 ms, p99: 15700 ms), latency samples: 180660
2. Upgrading first Validator to new version: d0b921dc483f434faa12204dc6be11923c530bdd
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1779 txn/s, latency: 15828 ms, (p50: 19000 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92520
3. Upgrading rest of first batch to new version: d0b921dc483f434faa12204dc6be11923c530bdd
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1250 txn/s, latency: 15867 ms, (p50: 19300 ms, p90: 21800 ms, p99: 22500 ms), latency samples: 92500
4. upgrading second batch to new version: d0b921dc483f434faa12204dc6be11923c530bdd
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3604 txn/s, latency: 8762 ms, (p50: 9800 ms, p90: 12400 ms, p99: 12700 ms), latency samples: 144160
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd passed
Test Ok

github-actions[bot] avatar Nov 13 '23 19:11 github-actions[bot]

:white_check_mark: Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd

Compatibility test results for aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd (PR)
Upgrade the nodes to version: d0b921dc483f434faa12204dc6be11923c530bdd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4268 txn/s, latency: 4815 ms, (p50: 4800 ms, p90: 7600 ms, p99: 8100 ms), latency samples: 243280
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> d0b921dc483f434faa12204dc6be11923c530bdd passed
Test Ok

github-actions[bot] avatar Nov 13 '23 19:11 github-actions[bot]

Forge is running suite realistic_env_max_load on 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95

github-actions[bot] avatar Nov 14 '23 07:11 github-actions[bot]

Forge is running suite compat on aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95

github-actions[bot] avatar Nov 14 '23 07:11 github-actions[bot]

Forge is running suite framework_upgrade on aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95

github-actions[bot] avatar Nov 14 '23 07:11 github-actions[bot]

:white_check_mark: Forge suite compat success on aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95

Compatibility test results for aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3551 txn/s, latency: 6324 ms, (p50: 6600 ms, p90: 9000 ms, p99: 9500 ms), latency samples: 188240
2. Upgrading first Validator to new version: 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1792 txn/s, latency: 16386 ms, (p50: 19000 ms, p90: 22300 ms, p99: 22400 ms), latency samples: 93220
3. Upgrading rest of first batch to new version: 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1584 txn/s, latency: 17894 ms, (p50: 19300 ms, p90: 25900 ms, p99: 28800 ms), latency samples: 76060
4. upgrading second batch to new version: 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2945 txn/s, latency: 10780 ms, (p50: 9900 ms, p90: 20500 ms, p99: 23800 ms), latency samples: 114860
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95 passed
Test Ok

github-actions[bot] avatar Nov 14 '23 07:11 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95

two traffics test: inner traffic : committed: 7245 txn/s, submitted: 7286 txn/s, expired: 41 txn/s, latency: 4279 ms, (p50: 4200 ms, p90: 5400 ms, p99: 9900 ms), latency samples: 3513886
two traffics test : committed: 100 txn/s, latency: 2199 ms, (p50: 2300 ms, p90: 2600 ms, p99: 4300 ms), latency samples: 2040
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.196", "QsPosToProposal: max: 0.164, avg: 0.149", "ConsensusProposalToOrdered: max: 0.613, avg: 0.598", "ConsensusOrderedToCommit: max: 0.534, avg: 0.506", "ConsensusProposalToCommit: max: 1.138, avg: 1.104"]
Max round gap was 1 [limit 4] at version 1756339. Max no progress secs was 4.461356 [limit 10] at version 1756339.
Test Ok

github-actions[bot] avatar Nov 14 '23 07:11 github-actions[bot]

:white_check_mark: Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95

Compatibility test results for aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95 (PR)
Upgrade the nodes to version: 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4212 txn/s, latency: 4829 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 244300
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 2c77ce9483101d3c6dbc21dbfebbcb45f64c5a95 passed
Test Ok

github-actions[bot] avatar Nov 14 '23 07:11 github-actions[bot]

Forge is running suite framework_upgrade on aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7

github-actions[bot] avatar Nov 15 '23 18:11 github-actions[bot]

Forge is running suite compat on aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7

github-actions[bot] avatar Nov 15 '23 18:11 github-actions[bot]

Forge is running suite realistic_env_max_load on 85e9f5d4cfdb58632c51bd12043836e5701e3cc7

github-actions[bot] avatar Nov 15 '23 18:11 github-actions[bot]

:white_check_mark: Forge suite compat success on aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7

Compatibility test results for aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5095 txn/s, latency: 6457 ms, (p50: 6700 ms, p90: 9700 ms, p99: 10500 ms), latency samples: 193640
2. Upgrading first Validator to new version: 85e9f5d4cfdb58632c51bd12043836e5701e3cc7
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1781 txn/s, latency: 15951 ms, (p50: 18900 ms, p90: 22000 ms, p99: 22500 ms), latency samples: 92660
3. Upgrading rest of first batch to new version: 85e9f5d4cfdb58632c51bd12043836e5701e3cc7
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1615 txn/s, latency: 17036 ms, (p50: 19300 ms, p90: 21400 ms, p99: 26600 ms), latency samples: 79160
4. upgrading second batch to new version: 85e9f5d4cfdb58632c51bd12043836e5701e3cc7
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3153 txn/s, latency: 9671 ms, (p50: 9100 ms, p90: 12600 ms, p99: 25400 ms), latency samples: 126140
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7 passed
Test Ok

github-actions[bot] avatar Nov 15 '23 18:11 github-actions[bot]

:white_check_mark: Forge suite realistic_env_max_load success on 85e9f5d4cfdb58632c51bd12043836e5701e3cc7

two traffics test: inner traffic : committed: 8061 txn/s, latency: 4858 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10800 ms), latency samples: 3490720
two traffics test : committed: 100 txn/s, latency: 2310 ms, (p50: 2200 ms, p90: 2700 ms, p99: 3600 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.202, avg: 0.196", "QsPosToProposal: max: 0.150, avg: 0.141", "ConsensusProposalToOrdered: max: 0.583, avg: 0.557", "ConsensusOrderedToCommit: max: 0.509, avg: 0.490", "ConsensusProposalToCommit: max: 1.072, avg: 1.048"]
Max round gap was 1 [limit 4] at version 5537. Max no progress secs was 4.034632 [limit 10] at version 2314249.
Test Ok

github-actions[bot] avatar Nov 15 '23 18:11 github-actions[bot]

:white_check_mark: Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7

Compatibility test results for aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7 (PR)
Upgrade the nodes to version: 85e9f5d4cfdb58632c51bd12043836e5701e3cc7
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 7049 txn/s, latency: 4803 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 246720
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 85e9f5d4cfdb58632c51bd12043836e5701e3cc7 passed
Test Ok

github-actions[bot] avatar Nov 15 '23 18:11 github-actions[bot]