aptly icon indicating copy to clipboard operation
aptly copied to clipboard

fixup: publish concurrency

Open runitonmetal opened this issue 1 year ago • 4 comments

Fixes #1125

This MR addresses a concurrency issue with the api/publish endpoint, where concurrent PUTs typically fail. The MR in it self is not pretty, so consider this initial state of the MR a starting point of discussion. The commits are intentionally separated in order to make it as easy as possible to observe the failing test (and test it against other likely better code changes).

runitonmetal avatar Apr 01 '24 23:04 runitonmetal

I'm happy to fix this MR up if it's of interest. Beyond a better code change I suggest the commits are squashed ahead of merge, they are separated for the convenience of any reviewer.

runitonmetal avatar Apr 01 '24 23:04 runitonmetal

thanks a lot, looks interesting ! will look into it...

neolynx avatar Apr 03 '24 08:04 neolynx

could you rebase on master ? then the test should run and produce some errors, as you can see here: https://github.com/aptly-dev/aptly/pull/1271

thanks !

neolynx avatar Apr 17 '24 18:04 neolynx

Rebased on master and fixed comlipation/lint: https://github.com/aptly-dev/aptly/pull/1271

Could you check comments there, 1 test is failing, might be expected behavior now...

neolynx avatar Apr 20 '24 21:04 neolynx