Update the mirror test goldens, fix --capture on Python 3
Description of the Change
CI was failing due to the mirror test goldens being outdated, so those were updated, as well as --capture being fixed on Python 3.
Checklist
- [ ] unit-test added (if change is algorithm)
- [ ] functional test added/updated (if change is functional)
- [ ] man page updated (if applicable)
- [ ] bash completion updated (if applicable)
- [ ] documentation updated
- [x] author name in
AUTHORS
Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.
Comparison is base (
f1649a6) 74.85% compared to head (8b4a7be) 74.93%. Report is 4 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| pgp/openpgp.go | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
+ Coverage 74.85% 74.93% +0.07%
==========================================
Files 143 143
Lines 16187 16181 -6
==========================================
+ Hits 12117 12125 +8
+ Misses 3134 3122 -12
+ Partials 936 934 -2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
beautiful.
(not sure why codecov is failing, this PR did not touch any Go code files.)
oh ! I was working on the same, but I moved all unstable internet sources to s3, so we have reproducible testing.
however, I wonder if your python change would still be needed. could you check ?
I guess this is not needed anymore, thanks anyway !