aptly icon indicating copy to clipboard operation
aptly copied to clipboard

Fix the CodeCov Pipeline

Open reglim opened this issue 3 years ago • 2 comments

The code coverage has had some issues in the past, which are addressed by this change.

Fixes: #1164

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

I changed the go test command to output to the GOCOVERDIR and upgraded the ci to go version 1.20. I also had to fix some issues that the linter detected, mainly replacing unused parameters with _.

Why this change is important?

The coverage should be accurate and it's not bad to test on the latest go version either.

Checklist

  • [ ] unit-test added (if change is algorithm)
  • [ ] functional test added/updated (if change is functional)
  • [ ] man page updated (if applicable)
  • [ ] bash completion updated (if applicable)
  • [ ] documentation updated
  • [x] author name in AUTHORS

reglim avatar Mar 17 '23 10:03 reglim

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.96%. Comparing base (4bc2180) to head (c49b588).

:exclamation: Current head c49b588 differs from pull request most recent head c8ea704

Please upload reports for the commit c8ea704 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   74.81%   65.96%   -8.85%     
==========================================
  Files         144      143       -1     
  Lines       16248    16188      -60     
==========================================
- Hits        12156    10679    -1477     
- Misses       3152     4756    +1604     
+ Partials      940      753     -187     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 21 '23 10:09 codecov[bot]

not quite sure what this fixes... suggest to close

neolynx avatar Jun 08 '24 16:06 neolynx