API: Set Batch automatically?

[WilliamDEdwards]

Detailed Description

https://www.aptly.info/doc/api/publish/ documents the signing option Batch as:

should be set if passing passphrase

Wouldn't it make more sense to set Batch automatically (and internally) depending on whether Passphrase and PassphraseFile is set?

Context

I can imagine that requiring users to set Batch when a passphrase is set requires extra, unwanted validation on the API side.

Possible Implementation

N/A

Your Environment

N/A

[reglim]

I had a look at it and you're right it seems like Batch is kind of a useless option, since it would need to be set to true anyway because the api will time out when it tries to get the passphrase from stdin. As it happens, this isn't even validated, so a missing passphrase with Batch = false will result in the timeout I described earlier : /

I'll make a branch to set it to true by default.

[neolynx]

I think this would actually be a good idea...