aptly icon indicating copy to clipboard operation
aptly copied to clipboard

Add linkMethod relative symlink

Open vkaylee opened this issue 2 years ago • 4 comments

It may relate to Fixes #783

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Guide here Add linkMehod: absoluteSymlink, relativeSymlink

The default one is symlink. It will be treated as absoluteSymlink

Add to the document. Pull request here https://github.com/aptly-dev/www.aptly.info/pull/98

Checklist

  • [x] unit-test added (if change is algorithm)
  • [x] functional test added/updated (if change is functional)
  • [x] man page updated (if applicable)
  • [ ] bash completion updated (if applicable)
  • [x] documentation updated
  • [x] author name in AUTHORS

vkaylee avatar Jul 05 '22 08:07 vkaylee

Codecov Report

Merging #1092 (2d37175) into master (c9f5763) will increase coverage by 14.20%. The diff coverage is 77.27%.

@@             Coverage Diff             @@
##           master    #1092       +/-   ##
===========================================
+ Coverage   52.11%   66.31%   +14.20%     
===========================================
  Files          73      141       +68     
  Lines       11272    15906     +4634     
===========================================
+ Hits         5874    10548     +4674     
+ Misses       4832     4606      -226     
- Partials      566      752      +186     
Impacted Files Coverage Δ
main.go 0.00% <ø> (ø)
files/package_pool.go 67.02% <76.92%> (+3.59%) :arrow_up:
files/public.go 77.09% <77.77%> (+0.65%) :arrow_up:
cmd/db_recover.go 85.18% <0.00%> (ø)
cmd/publish_drop.go 90.90% <0.00%> (ø)
cmd/publish_update.go 83.67% <0.00%> (ø)
cmd/snapshot_create.go 79.12% <0.00%> (ø)
cmd/cmd.go 82.95% <0.00%> (ø)
cmd/publish_repo.go 100.00% <0.00%> (ø)
... and 98 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 11 '22 07:07 codecov[bot]

@vleedev failing tests should be fixed now, would you mind rebasing?

randombenj avatar Jul 13 '22 06:07 randombenj

@vleedev failing tests should be fixed now, would you mind rebasing?

It has been rebased. Could you trigger CI?

vkaylee avatar Jul 13 '22 08:07 vkaylee

Generally the changes look good, so thanks for your contribution! Two things however:

  • absoluteSymlink does not seem to work, it will create a hardlink, only symlink works, could you have a look at that
  • The rebasing seems to have gone wild, there are some commits from master also in this branch now, could you maybe fix this as well?

randombenj avatar Aug 11 '22 07:08 randombenj

Close due to inactivity ...

randombenj avatar May 01 '23 14:05 randombenj