aptly icon indicating copy to clipboard operation
aptly copied to clipboard

Adding authorisation options for API access

Open bpiraeus opened this issue 2 years ago • 5 comments

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • [ ] unit-test added (if change is algorithm)
  • [ ] functional test added/updated (if change is functional)
  • [ ] man page updated (if applicable)
  • [ ] bash completion updated (if applicable)
  • [ ] documentation updated
  • [ ] author name in AUTHORS

bpiraeus avatar Mar 13 '22 23:03 bpiraeus

I went through the failing tests, and unless I'm missing something, those are not from my changes, not sure what I can do about that short of refactoring someone else's code. I'm happy to muck around if needed, but you'd likely prefer someone with a lot more chops than myself to mitigate those issues.

bpiraeus avatar Mar 14 '22 14:03 bpiraeus

@bpiraeus It looks like mostly deprecation errors

  • https://github.com/golang/go/issues/44226
  • package golang.org/x/crypto/ssh/terminal is deprecated: this package moved to golang.org/x/term

If you want to, feel free to investigate if there are some simple fixes for the deprecated packages (x/term) seems to be quite an easy one, not sure about the crypto one ...

randombenj avatar Mar 14 '22 15:03 randombenj

Cleaned up a few oddballs in my code that gosimple flagged, also moved the terminal bits to the appropriate package, the pgp ones appear as if they're likely going to want 3rd party library.

bpiraeus avatar Mar 14 '22 21:03 bpiraeus

@bpiraeus I just re reviewd the changes in go.mod and it seems like you upgraded quite a lot of dependencies. Was this on purpose? I think if you just add the packages you need to add without upgrading the others it will 'fix' the linting.

I would propose to upgrade all the other deps in a sepparate change. What do you think?

randombenj avatar Mar 29 '22 14:03 randombenj